Changeset 41318

Timestamp:

08/25/2017 11:27:55 PM (7 years ago)

Author:

SergeyBiryukov

Message:

Formatting: In sanitize_title_with_dashes(), convert forward slash to hyphen on save.

Props corvidism, jtsternberg, GhostToast, alxndr.
Fixes #10792.

Location:

trunk

Files:

• src/wp-includes/formatting.php (modified) (1 diff)
• tests/phpunit/tests/formatting/SanitizeTitleWithDashes.php (modified) (1 diff)

trunk/src/wp-includes/formatting.php

@@ -2001 +2001 @@
         // Convert nbsp, ndash and mdash HTML entities to hyphens
         $title = str_replace( array( ' ', ' ', '–', '–', '—', '—' ), '-', $title );
+        // Convert forward slash to hyphen
+        $title = str_replace( '/', '-', $title );
 
         // Strip these characters entirely

trunk/tests/phpunit/tests/formatting/SanitizeTitleWithDashes.php

@@ -110 +110 @@
 
     /**
+     * @ticket 10792
+     */
+    function test_replaces_forward_slash() {
+        $this->assertEquals("songs-by-lennon-mccartney", sanitize_title_with_dashes("songs by Lennon/McCartney", '', 'save'));
+        $this->assertEquals("songs-by-lennon-mccartney", sanitize_title_with_dashes("songs by Lennon//McCartney", '', 'save'));
+        $this->assertEquals("songs-by-lennon-mccartney", sanitize_title_with_dashes("songs by Lennon///McCartney", '', 'save'));
+        $this->assertEquals("songs-by-lennon-mccartney", sanitize_title_with_dashes("songs by Lennon/-McCartney", '', 'save'));
+        $this->assertEquals("songs-by-lennon-mccartney", sanitize_title_with_dashes("//songs by Lennon/McCartney", '', 'save'));
+    }
+
+    /**
      * @ticket 19820
      */