Changeset 41323

Timestamp:

08/30/2017 03:03:08 PM (7 years ago)

Author:

joemcgill

Message:

Media: Ensure 'media_handle_upload()' returns 'WP_Error' on failure.

This fixes an issue where failures when inserting the attachment post via
wp_insert_attachment() would result in a return value of 0 instead of a
WP_Error object, as documented. This is addressed by passing true as the
fourth param (added in WP 4.7.0) when calling wp_insert_attachment().

Props mrasharirfan, flixos90.
Fixes #41726.

File:

• trunk/src/wp-admin/includes/media.php (modified) (1 diff)

trunk/src/wp-admin/includes/media.php

@@ -379 +379 @@
 
     // Save the data
-    $id = wp_insert_attachment($attachment, $file, $post_id);
+    $id = wp_insert_attachment( $attachment, $file, $post_id, true );
     if ( !is_wp_error($id) ) {
         wp_update_attachment_metadata( $id, wp_generate_attachment_metadata( $id, $file ) );