Changeset 41359

Timestamp:

09/09/2017 02:49:53 PM (7 years ago)

Author:

afercia

Message:

Administration: Admin menu: Use aria-current for the current active page.

The aria-current attribute is a simple, effective way to communicate to assistive
technologies which the current item within a set of items is. While the admin menu
structure isn't 100% ideal (the top-level item is repeated also as a sub-item)
adding aria-current="page" to the sub-items gives an important feedback to
assistive technologies users.

This change introduces aria-current for the first time in core. Worth noting
there are other places where it can be used to improve accessibility. These should
be addressed in separate tickets and patches.

Fixes #41589.

File:

• trunk/src/wp-admin/menu-header.php (modified) (5 diffs)

trunk/src/wp-admin/menu-header.php

@@ -90 +90 @@
 
         if ( ( $parent_file && $item[2] == $parent_file ) || ( empty($typenow) && $self == $item[2] ) ) {
-            $class[] = ! empty( $submenu_items ) ? 'wp-has-current-submenu wp-menu-open' : 'current';
+            if ( ! empty( $submenu_items ) ) {
+                $class[] = 'wp-has-current-submenu wp-menu-open';
+            } else {
+                $class[] = 'current';
+                $aria_attributes .= 'aria-current="page"';
+            }
         } else {
             $class[] = 'wp-not-current-submenu';
@@ -179 +184 @@
 
                 $class = array();
+                $aria_attributes = '';
                 if ( $first ) {
                     $class[] = 'wp-first-item';
@@ -193 +199 @@
 
                 if ( isset( $submenu_file ) ) {
-                    if ( $submenu_file == $sub_item[2] )
+                    if ( $submenu_file == $sub_item[2] ) {
                         $class[] = 'current';
+                        $aria_attributes .= ' aria-current="page"';
+                    }
                 // If plugin_page is set the parent must either match the current page or not physically exist.
                 // This allows plugin pages with the same hook to exist under different parents.
@@ -202 +210 @@
                 ) {
                     $class[] = 'current';
+                    $aria_attributes .= ' aria-current="page"';
                 }
 
@@ -225 +234 @@
 
                     $sub_item_url = esc_url( $sub_item_url );
-                    echo "<li$class><a href='$sub_item_url'$class>$title</a></li>";
+                    echo "<li$class><a href='$sub_item_url'$class$aria_attributes>$title</a></li>";
                 } else {
-                    echo "<li$class><a href='{$sub_item[2]}'$class>$title</a></li>";
+                    echo "<li$class><a href='{$sub_item[2]}'$class$aria_attributes>$title</a></li>";
                 }
             }