Changeset 41374 for trunk/src/wp-includes/class-wp-customize-manager.php

Timestamp:

09/12/2017 07:02:49 AM (7 years ago)

Author:

westonruter

Message:

Customize: Add global notifications area.

• Displays an error notification in the global area when a save attempt is rejected due to invalid settings. An error notification is also displayed when saving fails due to a network error or server error.
• Introduces wp.customize.Notifications subclass of wp.customize.Values to contain instances of wp.customize.Notification and manage their rendering into a container.
• Exposes the global notification area as wp.customize.notifications collection instance.
• Updates the notifications object on Control to use Notifications rather than Values and to re-use the rendering logic from the former. The old Control#renderNotifications method is deprecated.
• Allows notifications to be dismissed by instantiating them with a dismissible property.
• Allows wp.customize.Notification to be extended with custom templates and render functions.
• Triggers a removed event on wp.customize.Values instances _after_ a value has been removed from the collection.

Props delawski, westonruter, karmatosed, celloexpressions, Fab1en, melchoyce, Kelderic, afercia, adamsilverstein.
See #34893, #39896.
Fixes #35210, #31582, #37727, #37269.

File:

• trunk/src/wp-includes/class-wp-customize-manager.php (modified) (3 diffs)

trunk/src/wp-includes/class-wp-customize-manager.php

@@ -349 +349 @@
         add_action( 'customize_controls_enqueue_scripts', array( $this, 'enqueue_control_scripts' ) );
 
-        // Render Panel, Section, and Control templates.
+        // Render Common, Panel, Section, and Control templates.
         add_action( 'customize_controls_print_footer_scripts', array( $this, 'render_panel_templates' ), 1 );
         add_action( 'customize_controls_print_footer_scripts', array( $this, 'render_section_templates' ), 1 );
@@ -2356 +2356 @@
             $response = array(
                 'setting_validities' => $setting_validities,
-                'message' => sprintf( _n( 'There is %s invalid setting.', 'There are %s invalid settings.', $invalid_setting_count ), number_format_i18n( $invalid_setting_count ) ),
+                /* translators: placeholder is number of invalid settings */
+                'message' => sprintf( _n( 'Unable to save due to %s invalid setting.', 'Unable to save due to %s invalid settings.', $invalid_setting_count ), number_format_i18n( $invalid_setting_count ) ),
             );
             return new WP_Error( 'transaction_fail', '', $response );
@@ -3184 +3185 @@
             $control->print_template();
         }
+
+        ?>
+        <script type="text/html" id="tmpl-customize-notification">
+            <li class="notice notice-{{ data.type || 'info' }} {{ data.alt ? 'notice-alt' : '' }} {{ data.dismissible ? 'is-dismissible' : '' }}" data-code="{{ data.code }}" data-type="{{ data.type }}">
+                {{{ data.message || data.code }}}
+                <# if ( data.dismissible ) { #>
+                    <button type="button" class="notice-dismiss"><span class="screen-reader-text"><?php _e( 'Dismiss' ); ?></span></button>
+                <# } #>
+            </li>
+        </script>
+
+        <?php
+        /* The following template is obsolete in core but retained for plugins. */
         ?>
         <script type="text/html" id="tmpl-customize-control-notifications">