WordPress.org

Make WordPress Core


Ignore:
Timestamp:
09/19/2017 10:10:35 AM (3 years ago)
Author:
johnbillion
Message:

General: Add missing URL-encoding and add extra hardening to plugin and template names when they're displayed in the admin area.

Props kawauso, Mte90 for initial patches

Fixes #13377

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-admin/plugins.php

    r41290 r41399  
    1818$action = $wp_list_table->current_action();
    1919
    20 $plugin = isset($_REQUEST['plugin']) ? $_REQUEST['plugin'] : '';
     20$plugin = isset($_REQUEST['plugin']) ? wp_unslash( $_REQUEST['plugin'] ) : '';
    2121$s = isset($_REQUEST['s']) ? urlencode( wp_unslash( $_REQUEST['s'] ) ) : '';
    2222
     
    4141            check_admin_referer('activate-plugin_' . $plugin);
    4242
    43             $result = activate_plugin($plugin, self_admin_url('plugins.php?error=true&plugin=' . $plugin), is_network_admin() );
     43            $result = activate_plugin($plugin, self_admin_url('plugins.php?error=true&plugin=' . urlencode( $plugin ) ), is_network_admin() );
    4444            if ( is_wp_error( $result ) ) {
    4545                if ( 'unexpected_output' == $result->get_error_code() ) {
    46                     $redirect = self_admin_url('plugins.php?error=true&charsout=' . strlen($result->get_error_data()) . '&plugin=' . $plugin . "&plugin_status=$status&paged=$page&s=$s");
     46                    $redirect = self_admin_url('plugins.php?error=true&charsout=' . strlen($result->get_error_data()) . '&plugin=' . urlencode( $plugin ) . "&plugin_status=$status&paged=$page&s=$s");
    4747                    wp_redirect(add_query_arg('_error_nonce', wp_create_nonce('plugin-activation-error_' . $plugin), $redirect));
    4848                    exit;
     
    7575            check_admin_referer('bulk-plugins');
    7676
    77             $plugins = isset( $_POST['checked'] ) ? (array) $_POST['checked'] : array();
     77            $plugins = isset( $_POST['checked'] ) ? (array) wp_unslash( $_POST['checked'] ) : array();
    7878
    7979            if ( is_network_admin() ) {
     
    128128
    129129            if ( isset( $_GET['plugins'] ) )
    130                 $plugins = explode( ',', $_GET['plugins'] );
     130                $plugins = explode( ',', wp_unslash( $_GET['plugins'] ) );
    131131            elseif ( isset( $_POST['checked'] ) )
    132                 $plugins = (array) $_POST['checked'];
     132                $plugins = (array) wp_unslash( $_POST['checked'] );
    133133            else
    134134                $plugins = array();
     
    206206            check_admin_referer('bulk-plugins');
    207207
    208             $plugins = isset( $_POST['checked'] ) ? (array) $_POST['checked'] : array();
     208            $plugins = isset( $_POST['checked'] ) ? (array) wp_unslash( $_POST['checked'] ) : array();
    209209            // Do not deactivate plugins which are already deactivated.
    210210            if ( is_network_admin() ) {
     
    251251
    252252            //$_POST = from the plugin form; $_GET = from the FTP details screen.
    253             $plugins = isset( $_REQUEST['checked'] ) ? (array) $_REQUEST['checked'] : array();
     253            $plugins = isset( $_REQUEST['checked'] ) ? (array) wp_unslash( $_REQUEST['checked'] ) : array();
    254254            if ( empty( $plugins ) ) {
    255255                wp_redirect( self_admin_url("plugins.php?plugin_status=$status&paged=$page&s=$s") );
     
    385385            if ( isset( $_POST['checked'] ) ) {
    386386                check_admin_referer('bulk-plugins');
    387                 $plugins = isset( $_POST['checked'] ) ? (array) $_POST['checked'] : array();
     387                $plugins = isset( $_POST['checked'] ) ? (array) wp_unslash( $_POST['checked'] ) : array();
    388388                $sendback = wp_get_referer();
    389389
Note: See TracChangeset for help on using the changeset viewer.