Changeset 41403 for branches/4.5

Timestamp:

09/19/2017 10:15:01 AM (8 years ago)

Author:

ocean90

Message:

Editor: Prevent adding javascript: and data: URLs through the inline link dialog.

Merge of [41393] to the 4.5 branch.

Location:

branches/4.5

Files:

• . (modified) (1 prop)
• src/wp-includes/js/tinymce/plugins/wplink/plugin.js (modified) (2 diffs)
• src/wp-includes/js/wplink.js (modified) (3 diffs)

branches/4.5/src/wp-includes/js/tinymce/plugins/wplink/plugin.js

@@ -5 +5 @@
             return (
                 '<div id="' + this._id + '" class="wp-link-preview">' +
-                    '<a href="' + this.url + '" target="_blank" tabindex="-1">' + this.url + '</a>' +
+                    '<a href="' + this.url + '" target="_blank" rel="noopener" tabindex="-1">' + this.url + '</a>' +
                 '</div>'
             );
@@ -217 +217 @@
                 text = inputInstance.getLinkText();
                 editor.focus();
+
+                var parser = document.createElement( 'a' );
+                parser.href = href;
+
+                if ( 'javascript:' === parser.protocol || 'data:' === parser.protocol ) { // jshint ignore:line
+                    href = '';
+                }
 
                 if ( ! href ) {

branches/4.5/src/wp-includes/js/wplink.js

@@ -314 +314 @@
 
             if ( attrs.target ) {
-                html += ' target="' + attrs.target + '"';
+                html += ' rel="noopener" target="' + attrs.target + '"';
             }
 
@@ -338 +338 @@
             attrs = wpLink.getAttrs();
             text = inputs.text.val();
+
+            var parser = document.createElement( 'a' );
+            parser.href = attrs.href;
+
+            if ( 'javascript:' === parser.protocol || 'data:' === parser.protocol ) { // jshint ignore:line
+                attrs.href = '';
+            }
 
             // If there's no href, return.
@@ -394 +401 @@
                 editor.selection.moveToBookmark( editor.windowManager.wplinkBookmark );
                 editor.windowManager.wplinkBookmark = null;
+            }
+
+            var parser = document.createElement( 'a' );
+            parser.href = attrs.href;
+
+            if ( 'javascript:' === parser.protocol || 'data:' === parser.protocol ) { // jshint ignore:line
+                attrs.href = '';
             }