Changeset 41549 for trunk/tests/phpunit/tests/widgets/media-image-widget.php

Timestamp:

09/20/2017 07:44:13 PM (9 years ago)

Author:

westonruter

Message:

Widgets: Omit attributes from an Image widget's link when they are empty.

Props subrataemfluence, Nenad Obradovic, westonruter.
See #39993.
Fixes #41919.

File:

• trunk/tests/phpunit/tests/widgets/media-image-widget.php (modified) (2 diffs)

trunk/tests/phpunit/tests/widgets/media-image-widget.php

@@ -394 +394 @@
                 $link = '<a href="' . wp_get_attachment_url( $attachment_id ) . '"';
                 $this->assertContains( $link, $output );
-                $link .= ' class=""';
-                $this->assertContains( $link, $output );
-                $link .= ' rel=""';
-                $this->assertContains( $link, $output );
-                $link .= ' target=""';
-                $this->assertContains( $link, $output );
+                $this->assertTrue( (bool) preg_match( '#<a href.*?>#', $output, $matches ) );
+                $this->assertNotContains( ' class="', $matches[0] );
+                $this->assertNotContains( ' rel="', $matches[0] );
+                $this->assertNotContains( ' target="', $matches[0] );
 
                 ob_start();
@@ -414 +412 @@
                 $this->assertContains( 'class="custom-link-class"', $output );
                 $this->assertContains( 'rel="attachment"', $output );
-                $this->assertContains( 'target=""', $output );
+                $this->assertNotContains( 'target=""', $output );
 
                 ob_start();