Changeset 41556

Timestamp:

09/21/2017 09:28:07 PM (7 years ago)

Author:

adamsilverstein

Message:

Login: Password reset - add hide icon & confirm weak password checkbox.

Extends the password features added in 4.3 to the password reset flow.

Props johnbillion, manolis09, umesh.nevase, Nikschavan.

Location:

trunk/src

Files:

• wp-admin/css/login.css (modified) (1 diff)
• wp-admin/js/user-profile.js (modified) (2 diffs)
• wp-login.php (modified) (1 diff)

trunk/src/wp-admin/css/login.css

@@ -72 +72 @@
     margin: 0;
     padding: 0;
+}
+
+.login .password-input-wrapper {
+    display: table;
+}
+
+.login .input.password-input {
+    display: table-cell;
+    margin: 0;
+}
+
+.login .pw-weak {
+    margin-bottom: 15px;
+}
+
+.login .button.button-secondary {
+    display: table-cell;
+    border-radius: 0;
+    vertical-align: middle;
 }
 

trunk/src/wp-admin/js/user-profile.js

@@ -162 +162 @@
         $('.user-pass2-wrap').hide();
 
-        $submitButton = $( '#submit' ).on( 'click', function () {
+        $submitButton = $( '#submit, #wp-submit' ).on( 'click', function () {
             updateLock = false;
         });
@@ -315 +315 @@
         if ( passStrength.className ) {
             $pass1.add( $pass1Text ).addClass( passStrength.className );
-            if ( 'short' === passStrength.className || 'bad' === passStrength.className ) {
+            if ( $( passStrength ).is( '.short, .bad' ) ) {
                 if ( ! $weakCheckbox.prop( 'checked' ) ) {
                     $submitButtons.prop( 'disabled', true );

trunk/src/wp-login.php

@@ -645 +645 @@
 
         <div class="wp-pwd">
-            <span class="password-input-wrapper">
-                <input type="password" data-reveal="1" data-pw="<?php echo esc_attr( wp_generate_password( 16 ) ); ?>" name="pass1" id="pass1" class="input" size="20" value="" autocomplete="off" aria-describedby="pass-strength-result" />
-            </span>
+            <div class="password-input-wrapper">
+                <input type="password" data-reveal="1" data-pw="<?php echo esc_attr( wp_generate_password( 16 ) ); ?>" name="pass1" id="pass1" class="input password-input" size="24" value="" autocomplete="off" aria-describedby="pass-strength-result" />
+                <span class="button button-secondary wp-hide-pw hide-if-no-js">
+                    <span class="dashicons dashicons-hidden"></span>
+                </span>
+            </div>
             <div id="pass-strength-result" class="hide-if-no-js" aria-live="polite"><?php _e( 'Strength indicator' ); ?></div>
+        </div>
+        <div class="pw-weak">
+            <label>
+                <input type="checkbox" name="pw_weak" class="pw-checkbox" />
+                <?php _e( 'Confirm use of weak password' ); ?>
+            </label>
         </div>
     </div>