Changeset 41590 for trunk/src/wp-includes/widgets/class-wp-widget-media.php

Timestamp:

09/25/2017 06:27:32 AM (2 years ago)

Author:

westonruter

Message:

Widgets: Introduce Gallery widget for displaying image galleries.

• Galleries are managed in the widget in the same way they are managed in the post editor, both using the media manager.
• Gallery widget is merged from the Core Media Widgets v0.2.0 feature plugin and it extends WP_Widget_Media in the same way as is done for image, audio, and video widgets.
• Model syncing logic is updated to support booleans and arrays (of integers).
• Placeholder areas in media widgets are now clickable shortcuts for selecting media.
• Image widget placeholder is updated to match gallery widget where clicking preview is shortcut for editing media.

Props westonruter, joemcgill, timmydcrawford, m1tk00, obenland, melchoyce.
See #32417.
Fixes #41914.

File:

• trunk/src/wp-includes/widgets/class-wp-widget-media.php (modified) (3 diffs)

trunk/src/wp-includes/widgets/class-wp-widget-media.php

@@ -258 +258 @@
             }
             $value = $new_instance[ $field ];
+
+            // Workaround for rest_validate_value_from_schema() due to the fact that rest_is_boolean( '' ) === false, while rest_is_boolean( '1' ) is true.
+            if ( 'boolean' === $field_schema['type'] && '' === $value ) {
+                $value = false;
+            }
+
             if ( true !== rest_validate_value_from_schema( $value, $field_schema, $field ) ) {
                 continue;
@@ -317 +323 @@
                 name="<?php echo esc_attr( $this->get_field_name( $name ) ); ?>"
                 id="<?php echo esc_attr( $this->get_field_id( $name ) ); // Needed specifically by wpWidgets.appendTitle(). ?>"
-                value="<?php echo esc_attr( strval( $value ) ); ?>"
+                value="<?php echo esc_attr( is_array( $value ) ? join( ',', $value ) : strval( $value ) ); ?>"
             />
         <?php
@@ -389 +395 @@
                 <input id="{{ elementIdPrefix }}title" type="text" class="widefat title">
             </p>
-            <div class="media-widget-preview">
+            <div class="media-widget-preview <?php echo esc_attr( $this->id_base ); ?>">
                 <div class="attachment-media-view">
                     <div class="placeholder"><?php echo esc_html( $this->l10n['no_media_selected'] ); ?></div>