Changeset 41595

Timestamp:

09/25/2017 09:45:57 PM (7 years ago)

Author:

westonruter

Message:

Code Editors: Update the current file highlight to use notice styling.

Improves color contrast and readability, and reuses a core design pattern.

Props kekkakokkers, monopine, Travel_girl, afercia, melchoyce, karmatosed.
Fixes #31604.

Location:

trunk/src/wp-admin

Files:

• css/common.css (modified) (1 diff)
• plugin-editor.php (modified) (1 diff)
• theme-editor.php (modified) (1 diff)

trunk/src/wp-admin/css/common.css

@@ -1462 +1462 @@
 }
 
+.wrap #templateside .notice {
+    display: block;
+    margin: 0;
+    padding: 5px 12px;
+    font-weight: 600;
+    text-decoration: none;
+}
+
+.wrap #templateside span.notice {
+  margin-left: -12px;
+}
+
+#templateside li.notice a {
+  padding: 0;
+}
+
 /* Update icon. */
 .update-message p:before,

trunk/src/wp-admin/plugin-editor.php

@@ -322 +322 @@
         continue;
     }
-?>
-        <li<?php echo $file == $plugin_file ? ' class="highlight"' : ''; ?>><a href="plugin-editor.php?file=<?php echo urlencode( $plugin_file ) ?>&amp;plugin=<?php echo urlencode( $plugin ) ?>"><?php echo esc_html( $plugin_file ); ?></a></li>
+    ?>
+    <li class="<?php echo esc_attr( $file === $plugin_file ? 'notice notice-info' : '' ); ?>"><a href="plugin-editor.php?file=<?php echo urlencode( $plugin_file ); ?>&amp;plugin=<?php echo urlencode( $plugin ); ?>"><?php echo esc_html( $plugin_file ); ?></a></li>
 <?php endforeach; ?>
     </ul>

trunk/src/wp-admin/theme-editor.php

@@ -284 +284 @@
 
         if ( $absolute_filename === $file ) {
-            $file_description = '<span class="highlight">' . $file_description . '</span>';
+            $file_description = '<span class="notice notice-info">' . $file_description . '</span>';
         }