Changeset 41624 for trunk/tests/phpunit/tests/user.php

Timestamp:

09/27/2017 09:09:11 PM (6 years ago)

Author:

flixos90

Message:

Multisite: Initialize a user's roles correctly when setting them up for a different site.

While it has always been possible to initialize a user's roles and capabilities for another site than the current one in a multisite, the actual roles available were not switched prior to this change, possibly causing invalid roles to show up or actually valid capabilities not being available.

In order to fix this bug in a clean way, relevant parts of the WP_User class have been refactored. The ID of the site for which capabilities are currently initialized are now stored in a private property WP_User::$site_id. The WP_User::for_blog( $blog_id ) and WP_User::_init_caps( $cap_key ) methods have been deprecated in favor of WP_User::for_site( $site_id ). In addition, a new method WP_User::get_site_id() has been introduced to retrieve the site ID for which the user's capabilities are currently initialized.

Props ryanduff, jeremyfelt, flixos90.
Fixes #36961.

File:

• trunk/tests/phpunit/tests/user.php (modified) (1 diff)

trunk/tests/phpunit/tests/user.php

@@ -181 +181 @@
         $this->assertEquals( 'foo', $user->data->$key );  // This will fail with WP < 3.3
 
-        foreach ( (array) $user as $key => $value ) {
+        foreach ( get_object_vars( $user ) as $key => $value ) {
             $this->assertEquals( $value, $user->$key );
         }