Changeset 41625 for trunk/tests/phpunit/tests/user/capabilities.php

Timestamp:

09/27/2017 09:43:59 PM (7 years ago)

Author:

flixos90

Message:

Multisite: Improve initializing available roles when switch sites.

Switching the available roles and the current user's capabilities no longer happens in switch_to_blog() and restore_current_blog(), instead it has been moved to a new function wp_switch_roles_and_user() which is hooked into the site switching process. This allows to improve performance by temporarily unhooking the function when roles and capabilities do not need to be switched.

This change ensures that switching available roles now works closer to switching user capabilities, particularly the changes in [41624]. A new WP_Roles::for_site( $site_id ) method has been introduced, and the WP_Roles::_init() method has been deprecated. It is furthermore possible to retrieve the site ID for which the available roles are currently initialized through a new WP_Roles::get_site_id().

Props johnjamesjacoby, flixos90.
Fixes #38645.

File:

• trunk/tests/phpunit/tests/user/capabilities.php (modified) (1 diff)

trunk/tests/phpunit/tests/user/capabilities.php

@@ -1940 +1940 @@
         $this->assertSame( 333, $user->get_site_id() );
     }
+
+    /**
+     * @ticket 38645
+     * @group ms-required
+     */
+    function test_init_roles_for_different_site() {
+        global $wpdb;
+
+        $site_id = self::factory()->blog->create();
+
+        switch_to_blog( $site_id );
+
+        $role_name = 'uploader';
+        add_role( $role_name, 'Uploader', array(
+            'read'         => true,
+            'upload_files' => true,
+        ) );
+
+        restore_current_blog();
+
+        $wp_roles = wp_roles();
+        $wp_roles->for_site( $site_id );
+
+        $this->assertTrue( isset( $wp_roles->role_objects[ $role_name ] ) );
+    }
+
+    /**
+     * @ticket 38645
+     */
+    function test_get_roles_data() {
+        global $wpdb;
+
+        $custom_roles = array(
+            'test_role' => array(
+                'name'         => 'Test Role',
+                'capabilities' => array(
+                    'do_foo' => true,
+                    'do_bar' => false,
+                ),
+            ),
+        );
+
+        // Test `WP_Roles::get_roles_data()` by manually setting the roles option.
+        update_option( $wpdb->get_blog_prefix( get_current_blog_id() ) . 'user_roles', $custom_roles );
+
+        $roles = new WP_Roles();
+        $this->assertSame( $custom_roles, $roles->roles );
+    }
+
+    /**
+     * @ticket 38645
+     */
+    function test_roles_get_site_id_default() {
+        $roles = new WP_Roles();
+        $this->assertSame( get_current_blog_id(), $roles->get_site_id() );
+    }
+
+    /**
+     * @ticket 38645
+     */
+    function test_roles_get_site_id() {
+        global $wpdb;
+
+        // Suppressing errors here allows to get around creating an actual site,
+        // which is unnecessary for this test.
+        $suppress = $wpdb->suppress_errors();
+        $roles = new WP_Roles( 333 );
+        $wpdb->suppress_errors( $suppress );
+
+        $this->assertSame( 333, $roles->get_site_id() );
+    }
 }