Changeset 41643

Timestamp:

09/29/2017 02:24:19 PM (7 years ago)

Author:

azaozz

Message:

TinyMCE: fix "flickering inline toolbar" in Chrome in RTL mode by not showing tooltips while an inline toolbar is shown.

Fixes #42018.

Location:

trunk/src/wp-includes

Files:

• css/editor.css (modified) (1 diff)
• js/tinymce/plugins/wordpress/plugin.js (modified) (2 diffs)

trunk/src/wp-includes/css/editor.css

@@ -761 +761 @@
 .mce-tooltip {
     margin-top: 2px;
+}
+
+/* Don't show the tooltip. Used in Chrome RTL, see #42018 */
+.rtl .mce-tooltip.wp-hide-mce-tooltip {
+    display: none !important;
 }
 

trunk/src/wp-includes/js/tinymce/plugins/wordpress/plugin.js

@@ -686 +686 @@
             mceToolbar,
             mceStatusbar,
-            wpStatusbar;
+            wpStatusbar,
+            isChromeRtl = ( editor.rtl && /Chrome/.test( navigator.userAgent ) );
 
             if ( container ) {
@@ -930 +931 @@
             toolbar.on( 'show', function() {
                 this.reposition();
+
+                if ( isChromeRtl ) {
+                    tinymce.$( '.mce-widget.mce-tooltip' ).addClass( 'wp-hide-mce-tooltip' );
+                }
+            } );
+
+            toolbar.on( 'hide', function() {
+                if ( isChromeRtl ) {
+                    tinymce.$( '.mce-widget.mce-tooltip' ).removeClass( 'wp-hide-mce-tooltip' );
+                }
             } );