Changeset 41665

Timestamp:

10/02/2017 03:08:18 AM (7 years ago)

Author:

jeremyfelt

Message:

Multisite: Only update a site's post count when post types of post are updated.

Previously, the query to update the count of published posts would run every time any post type transitioned between a publish/non-published status or was deleted.

Props sboisvert, JPry, spacedmonkey.
Fixes #42021.

Location:

trunk/src/wp-includes

Files:

• ms-blogs.php (modified) (2 diffs)
• ms-default-filters.php (modified) (1 diff)

trunk/src/wp-includes/ms-blogs.php

@@ -1286 +1286 @@
     $post = get_post( $post_id );
 
-    if ( ! $post || 'publish' !== $post->post_status ) {
+    if ( ! $post || 'publish' !== $post->post_status || 'post' !== $post->post_type ) {
         return;
     }
@@ -1297 +1297 @@
  *
  * @since 4.0.0
- *
- * @param string $new_status The status the post is changing to.
- * @param string $old_status The status the post is changing from.
- */
-function _update_posts_count_on_transition_post_status( $new_status, $old_status ) {
+ * @since 4.9.0 Added the `$post` parameter.
+ *
+ * @param string  $new_status The status the post is changing to.
+ * @param string  $old_status The status the post is changing from.
+ * @param WP_Post $post       Post object
+ */
+function _update_posts_count_on_transition_post_status( $new_status, $old_status, $post = null ) {
     if ( $new_status === $old_status ) {
         return;
     }
 
+    if ( 'post' !== get_post_type( $post ) ) {
+        return;
+    }
+
     if ( 'publish' !== $new_status && 'publish' !== $old_status ) {
         return;

trunk/src/wp-includes/ms-default-filters.php

@@ -55 +55 @@
 add_action( 'delete_post', '_update_blog_date_on_post_delete' );
 add_action( 'transition_post_status', '_update_blog_date_on_post_publish', 10, 3 );
-add_action( 'transition_post_status', '_update_posts_count_on_transition_post_status', 10, 2 );
+add_action( 'transition_post_status', '_update_posts_count_on_transition_post_status', 10, 3 );
 
 // Counts