Context Navigation

← Previous Change
Next Change →

CustomizeManager.php

Timestamp:

10/02/2017 03:36:18 AM (9 years ago)

Author:

westonruter

Message:

Customize: Add infrastructure for trashing/reverting of unpublished changes; introduce full-screen OverlayNotification for trashing and theme install/preview.

Introduce a new wp.customize.previewer.trash() JS API to trash the current changeset, along with logic to WP_Customize_Manager to handle deleting changeset drafts.
Add trashing to wp.customize.state which is then used to update the UI.
UI for trashing is pending design feedback. One possibility is to add a new trash button to Publish Settings section that invokes wp.customize.previewer.trash().
Improve logic for managing the visibility and disabled states for publish buttons.
Prevent attempting requestChangesetUpdate while processing and bump processing while doing save.
Update changeset_date state only if sent in save response.
Merge ThemesSection#loadThemePreview() into ThemesPanel#loadThemePreview().
Remove unused autosaved state.
Start autosaving and prompting at beforeunload after a change first happens. This is key for theme previews since even if a user did not make any changes, there were still dirty settings which would get stored in an auto-draft unexpectedly.
Allow Notification to accept additional classes to be added to container.
Introduce OverlayNotification and use for theme installing, previewing, and trashing. Such overlay notifications take over the entire window.

Props westonruter, celloexpressions.
See #37661, #39896, #21666, #35210.

File:

: 1 edited

trunk/tests/phpunit/tests/ajax/CustomizeManager.php (modified) (6 diffs)

Legend:

: Unmodified
: Added
: Removed

trunk/tests/phpunit/tests/ajax/CustomizeManager.php

-              r41626
+              r41667
         /**
          * Test request for dismissing autosave changesets.
+         * Test request for trashing a changeset.
+         *
          * @ticket 39896
+         * @covers WP_Customize_Manager::handle_dismiss_changeset_autosave_request()
+         * @covers WP_Customize_Manager::dismiss_user_auto_draft_changesets()
+         */
+        public function test_handle_dismiss_changeset_autosave_request() {
+         * @covers WP_Customize_Manager::handle_changeset_trash_request()
+         */
+        public function test_handle_changeset_trash_request() {
                 $uuid = wp_generate_uuid4();
                 $wp_customize = $this->set_up_valid_state( $uuid );
+                $this->make_ajax_call( 'dismiss_customize_changeset_autosave' );
+                $this->make_ajax_call( 'customize_trash' );
+                $this->assertFalse( $this->_last_response_parsed['success'] );
+                $this->assertEquals( 'invalid_nonce', $this->_last_response_parsed['data']['code'] );
+                $nonce = wp_create_nonce( 'trash_customize_changeset' );
+                $_POST['nonce'] = $_GET['nonce'] = $_REQUEST['nonce'] = $nonce;
+                $this->make_ajax_call( 'customize_trash' );
+                $this->assertFalse( $this->_last_response_parsed['success'] );
+                $this->assertEquals( 'non_existent_changeset', $this->_last_response_parsed['data']['code'] );
+                $wp_customize->register_controls(); // And settings too.
+                $wp_customize->set_post_value( 'blogname', 'HELLO' );
+                $wp_customize->save_changeset_post( array(
+                        'status' => 'save',
+                ) );
+                add_filter( 'map_meta_cap', array( $this, 'return_do_not_allow' ) );
+                $this->make_ajax_call( 'customize_trash' );
+                $this->assertFalse( $this->_last_response_parsed['success'] );
+                $this->assertEquals( 'changeset_trash_unauthorized', $this->_last_response_parsed['data']['code'] );
+                remove_filter( 'map_meta_cap', array( $this, 'return_do_not_allow' ) );
+                wp_update_post( array(
+                        'ID' => $wp_customize->changeset_post_id(),
+                        'post_status' => 'trash',
+                ) );
+                $this->make_ajax_call( 'customize_trash' );
+                $this->assertFalse( $this->_last_response_parsed['success'] );
+                $this->assertEquals( 'changeset_already_trashed', $this->_last_response_parsed['data']['code'] );
+                wp_update_post( array(
+                        'ID' => $wp_customize->changeset_post_id(),
+                        'post_status' => 'draft',
+                ) );
+                $wp_trash_post_count = did_action( 'wp_trash_post' );
+                add_filter( 'pre_trash_post', '__return_false' );
+                $this->make_ajax_call( 'customize_trash' );
+                $this->assertFalse( $this->_last_response_parsed['success'] );
+                $this->assertEquals( 'changeset_trash_failure', $this->_last_response_parsed['data']['code'] );
+                remove_filter( 'pre_trash_post', '__return_false' );
+                $this->assertEquals( $wp_trash_post_count, did_action( 'wp_trash_post' ) );
+                $wp_trash_post_count = did_action( 'wp_trash_post' );
+                $this->assertEquals( 'draft', get_post_status( $wp_customize->changeset_post_id() ) );
+                $this->make_ajax_call( 'customize_trash' );
+                $this->assertTrue( $this->_last_response_parsed['success'] );
+                $this->assertEquals( 'trash', get_post_status( $wp_customize->changeset_post_id() ) );
+                $this->assertEquals( $wp_trash_post_count + 1, did_action( 'wp_trash_post' ) );
+        }
+        /**
+         * Return caps array containing 'do_not_allow'.
+         *
+         * @return array Caps.
+         */
+        public function return_do_not_allow() {
+                return array( 'do_not_allow' );
+        }
+        /**
+         * Test request for dismissing autosave changesets.
+         *
+         * @ticket 39896
+         * @covers WP_Customize_Manager::handle_dismiss_autosave_request()
+         * @covers WP_Customize_Manager::dismiss_user_auto_draft_changesets()
+         */
+        public function test_handle_dismiss_autosave_request() {
+                $uuid = wp_generate_uuid4();
+                $wp_customize = $this->set_up_valid_state( $uuid );
+                $this->make_ajax_call( 'customize_dismiss_autosave' );
                 $this->assertFalse( $this->_last_response_parsed['success'] );
                 $this->assertEquals( 'invalid_nonce', $this->_last_response_parsed['data'] );
                 $nonce = wp_create_nonce( 'dismiss_customize_changeset_autosave' );
+                $nonce = wp_create_nonce( 'customize_dismiss_autosave' );
                 $_POST['nonce'] = $_GET['nonce'] = $_REQUEST['nonce'] = $nonce;
                 $this->make_ajax_call( 'dismiss_customize_changeset_autosave' );
+                $this->make_ajax_call( 'customize_dismiss_autosave' );
                 $this->assertFalse( $this->_last_response_parsed['success'] );
                 $this->assertEquals( 'no_auto_draft_to_delete', $this->_last_response_parsed['data'] );
 …
                         $this->assertFalse( (bool) get_post_meta( $post_id, '_customize_restore_dismissed', true ) );
+                }
                 $this->make_ajax_call( 'dismiss_customize_changeset_autosave' );
+                $this->make_ajax_call( 'customize_dismiss_autosave' );
                 $this->assertTrue( $this->_last_response_parsed['success'] );
                 $this->assertEquals( 'auto_draft_dismissed', $this->_last_response_parsed['data'] );
 …
                 // Subsequent test results in none dismissed.
                 $this->make_ajax_call( 'dismiss_customize_changeset_autosave' );
+                $this->make_ajax_call( 'customize_dismiss_autosave' );
                 $this->assertFalse( $this->_last_response_parsed['success'] );
                 $this->assertEquals( 'no_auto_draft_to_delete', $this->_last_response_parsed['data'] );
 …
                 // Since no autosave yet, confirm no action.
                 $this->make_ajax_call( 'dismiss_customize_changeset_autosave' );
+                $this->make_ajax_call( 'customize_dismiss_autosave' );
                 $this->assertFalse( $this->_last_response_parsed['success'] );
                 $this->assertEquals( 'no_autosave_revision_to_delete', $this->_last_response_parsed['data'] );
 …
                 // Confirm autosave gets deleted.
                 $this->make_ajax_call( 'dismiss_customize_changeset_autosave' );
+                $this->make_ajax_call( 'customize_dismiss_autosave' );
                 $this->assertTrue( $this->_last_response_parsed['success'] );
                 $this->assertEquals( 'autosave_revision_deleted', $this->_last_response_parsed['data'] );
 …
                 // Since no autosave yet, confirm no action.
                 $this->make_ajax_call( 'dismiss_customize_changeset_autosave' );
+                $this->make_ajax_call( 'customize_dismiss_autosave' );
                 $this->assertFalse( $this->_last_response_parsed['success'] );
                 $this->assertEquals( 'no_autosave_revision_to_delete', $this->_last_response_parsed['data'] );

Note: See TracChangeset for help on using the changeset viewer.

Make WordPress Core

Context Navigation

Changeset 41667 for trunk/tests/phpunit/tests/ajax/CustomizeManager.php

Legend:

trunk/tests/phpunit/tests/ajax/CustomizeManager.php

Download in other formats: