Changeset 41683 for trunk/src/wp-admin/includes/class-wp-users-list-table.php

Timestamp:

10/02/2017 07:43:02 PM (6 years ago)

Author:

afercia

Message:

Accessibility: List Tables: use aria-current for the views current link.

The aria-current attribute is a simple, effective way to help assistive
technologies users orientate themselves within a list of items. Continues the
introduction in core of the aria-current attribute after [41359] and [41371].

Props joedolson, flixos90, afercia.
Fixes #32399.

File:

• trunk/src/wp-admin/includes/class-wp-users-list-table.php (modified) (4 diffs)

trunk/src/wp-admin/includes/class-wp-users-list-table.php

@@ -197 +197 @@
         }
 
-        $class = empty($role) ? ' class="current"' : '';
+        $current_link_attributes = empty( $role ) ? ' class="current" aria-current="page"' : '';
+
         $role_links = array();
 
         if ( $count_users ) {
-            $role_links['all'] = "<a href='$url'$class>" . sprintf( _nx( 'All <span class="count">(%s)</span>', 'All <span class="count">(%s)</span>', $total_users, 'users' ), number_format_i18n( $total_users ) ) . '</a>';
+            $role_links['all'] = "<a href='$url'$current_link_attributes>" . sprintf( _nx( 'All <span class="count">(%s)</span>', 'All <span class="count">(%s)</span>', $total_users, 'users' ), number_format_i18n( $total_users ) ) . '</a>';
         } else {
-            $role_links['all'] = "<a href='$url'$class>" . _x( 'All', 'users' ) . '</a>';
+            $role_links['all'] = "<a href='$url'$current_link_attributes>" . _x( 'All', 'users' ) . '</a>';
         }
         foreach ( $wp_roles->get_names() as $this_role => $name ) {
@@ -210 +211 @@
             }
 
-            $class = '';
+            $current_link_attributes = '';
 
             if ( $this_role === $role ) {
-                $class = ' class="current"';
+                $current_link_attributes = ' class="current" aria-current="page"';
             }
 
@@ -221 +222 @@
                 $name = sprintf( __('%1$s <span class="count">(%2$s)</span>'), $name, number_format_i18n( $avail_roles[$this_role] ) );
             }
-            $role_links[$this_role] = "<a href='" . esc_url( add_query_arg( 'role', $this_role, $url ) ) . "'$class>$name</a>";
+            $role_links[$this_role] = "<a href='" . esc_url( add_query_arg( 'role', $this_role, $url ) ) . "'$current_link_attributes>$name</a>";
         }
 
         if ( ! $count_users || ! empty( $avail_roles['none' ] ) ) {
 
-            $class = '';
+            $current_link_attributes = '';
 
             if ( 'none' === $role ) {
-                $class = ' class="current"';
+                $current_link_attributes = ' class="current" aria-current="page"';
             }
 
@@ -237 +238 @@
                 $name = sprintf( __('%1$s <span class="count">(%2$s)</span>'), $name, number_format_i18n( $avail_roles['none' ] ) );
             }
-            $role_links['none'] = "<a href='" . esc_url( add_query_arg( 'role', 'none', $url ) ) . "'$class>$name</a>";
+            $role_links['none'] = "<a href='" . esc_url( add_query_arg( 'role', 'none', $url ) ) . "'$current_link_attributes>$name</a>";
 
         }