Changeset 41695

Timestamp:

10/03/2017 12:24:31 AM (7 years ago)

Author:

pento

Message:

Plugins: Add plugin icons to the plugin list tables.

To mirror theme list table behaviour, the plugin icon now appears next to plugins in the plugin list tables. For plugins that don't have an icon, or non-W.org plugins, a fallback dashicon is shown.

Props melchoyce, afercia, paulwilde, pento, obenland.
Fixes #30186.

Location:

trunk/src/wp-admin

Files:

• css/list-tables.css (modified) (1 diff)
• includes/class-wp-plugins-list-table.php (modified) (1 diff)
• update-core.php (modified) (2 diffs)

trunk/src/wp-admin/css/list-tables.css

@@ -1287 +1287 @@
 }
 
-#wpbody-content .plugins .plugin-title,
-#wpbody-content .plugins .theme-title {
+.wp-list-table.plugins .plugin-title,
+.wp-list-table.plugins .theme-title {
+    white-space: nowrap;
+}
+
+.wp-list-table.plugins .theme-title {
     padding-right: 12px;
-    white-space:nowrap;
-}
-
-.updates-table-screenshot {
-    float:left;
-    padding: 0 10px 5px 0;
+}
+
+.wp-list-table.plugins .plugin-title {
+    padding-right: 86px; /* 64 (icon width) + 10 (icon padding) + 12 (title padding) = 86 */
+}
+
+.plugins .plugin-title img,
+.plugins .plugin-title .dashicons {
+    float: left;
+    padding: 0 10px 0 0;
+    width: 64px;
+    height: 64px;
+}
+
+.plugins .plugin-title .dashicons:before {
+    font-size: 64px;
+}
+
+#update-themes-table .plugin-title img,
+#update-themes-table .plugin-title .dashicons {
+    width: 85px;
 }
 

trunk/src/wp-admin/includes/class-wp-plugins-list-table.php

@@ -752 +752 @@
                     break;
                 case 'name':
-                    echo "<td class='plugin-title column-primary'><strong>$plugin_name</strong>";
-                    echo $this->row_actions( $actions, true );
-                    echo "</td>";
+                    $icon = '<span class="dashicons dashicons-admin-plugins"></span>';
+                    if ( ! empty( $plugin_data['icons']['default'] ) ) {
+                        $icon = '<img src="' . esc_url( $plugin_data['icons']['default'] ) . '" alt="" />';
+                    }
+                    ?>
+                    <td class="plugin-title column-primary">
+                        <?php echo $icon; ?>
+                        <strong><?php echo $plugin_name; ?></strong>
+                        <?php echo $this->row_actions( $actions, true ); ?>
+                    </td>
+                    <?php
                     break;
                 case 'description':

trunk/src/wp-admin/update-core.php

@@ -253 +253 @@
         $plugin_data = (object) _get_plugin_data_markup_translate( $plugin_file, (array) $plugin_data, false, true );
 
+        $icon = '<span class="dashicons dashicons-admin-plugins"></span>';
+        if ( ! empty( $plugin_data->update->icons['default'] ) ) {
+            $icon = '<img src="' . esc_url( $plugin_data->update->icons['default'] ) . '" alt="" />';
+        }
+
         // Get plugin compat for running version of WordPress.
         if ( isset($plugin_data->update->tested) && version_compare($plugin_data->update->tested, $cur_wp_version, '>=') ) {
@@ -303 +308 @@
             </td>
             <td class="plugin-title"><p>
+                <?php echo $icon; ?>
                 <strong><?php echo $plugin_data->Name; ?></strong>
                 <?php