Changeset 41701 for trunk/tests/phpunit/tests/formatting/Emoji.php

Timestamp:

10/03/2017 07:11:28 AM (8 years ago)

Author:

pento

Message:

Emoji: Bring Twemoji compatibility to PHP.

This was previously attempted in [41043], which unfortunately had severe performance issues, the regex it used was fatally slow on long posts.

This version now uses an array of all emoji that Twemoji supports, which maintains the accuracy of [41043], while being the same speed or only a few ms slower than the code prior to [41043].

As with [41043], the grunt precommit:emoji task detects when twemoji.js has changed, and regenerates the array.

Props jmdodd for feedback, suggestions, and insults where appropriate.
Fixes #35293. 🤞🏻

File:

• trunk/tests/phpunit/tests/formatting/Emoji.php (modified) (1 diff)

trunk/tests/phpunit/tests/formatting/Emoji.php

@@ -63 +63 @@
 
     /**
-     * @ticket 35293
+     * @ticket 41501
      */
-    public function test_wp_emoji_regex_returns_regexen() {
-        $default = wp_emoji_regex();
+    public function test_wp_emoji_list_returns_data() {
+        $default = _wp_emoji_list();
         $this->assertNotEmpty( $default );
 
-        $codepoints = wp_emoji_regex( 'codepoints' );
-        $this->assertNotEmpty( $codepoints );
-
-        $this->assertSame( $default, $codepoints );
-
-        $entities = wp_emoji_regex( 'entities' );
+        $entities = _wp_emoji_list( 'entities' );
         $this->assertNotEmpty( $entities );
 
-        $this->assertNotSame( $default, $entities );
+        $this->assertSame( $default, $entities );
+
+        $partials = _wp_emoji_list( 'partials' );
+        $this->assertNotEmpty( $partials );
+
+        $this->assertNotSame( $default, $partials );
     }