Changeset 41732 for trunk/src/wp-admin/custom-header.php

Timestamp:

10/04/2017 02:58:07 PM (9 years ago)

Author:

joemcgill

Message:

Customizer: Minimize duplicate header crops in the media library.

This adds Custom_Image_Header::get_previous_crop(), which finds any
previously cropped headers created from the same base image and replaces
that attachment rather than creating a new attachment.

After updating a crop, the replaced images is also removed from the list
of previous header images in the Customizer.

See #21819.

File:

• trunk/src/wp-admin/custom-header.php (modified) (5 diffs)

trunk/src/wp-admin/custom-header.php

@@ -1165 +1165 @@
                         'post_mime_type' => $image_type,
                         'guid' => $url,
-                        'context' => 'custom-header'
+                        'context' => 'custom-header',
+                        'post_parent' => $parent_attachment_id,
                 );
 
@@ -1181 +1182 @@
          */
         final public function insert_attachment( $object, $cropped ) {
+                $parent_id = isset( $object['post_parent'] ) ? $object['post_parent'] : null;
+                unset( $object['post_parent'] );
+
                 $attachment_id = wp_insert_attachment( $object, $cropped );
                 $metadata = wp_generate_attachment_metadata( $attachment_id, $cropped );
+
                 /**
                  * Filters the header image attachment metadata.
@@ -1194 +1199 @@
                 $metadata = apply_filters( 'wp_header_image_attachment_metadata', $metadata );
                 wp_update_attachment_metadata( $attachment_id, $metadata );
+
+                if ( $parent_id ) {
+                        $meta = add_post_meta( $attachment_id, '_wp_attachment_parent', $parent_id, true );
+                }
+
                 return $attachment_id;
         }
@@ -1242 +1252 @@
                 $object = $this->create_attachment_object( $cropped, $attachment_id );
 
-                unset( $object['ID'] );
+                $previous = $this->get_previous_crop( $object );
+
+                if ( $previous ) {
+                        $object['ID'] = $previous;
+                } else {
+                        unset( $object['ID'] );
+                }
 
                 $new_attachment_id = $this->insert_attachment( $object, $cropped );
@@ -1397 +1413 @@
                 return $header_images;
         }
+
+        /**
+         * Get the ID of a previous crop from the same base image.
+         *
+         * @since 4.9.0
+         *
+         * @param  array $object A crop attachment object.
+         * @return int|false An attachment ID if one exists. False if none.
+         */
+        public function get_previous_crop( $object ) {
+                $header_images = $this->get_uploaded_header_images();
+
+                // Bail early if there are no header images.
+                if ( empty( $header_images ) ) {
+                        return false;
+                }
+
+                $previous = false;
+
+                foreach ( $header_images as $image ) {
+                        if ( $image['attachment_parent'] === $object['post_parent'] ) {
+                                $previous = $image['attachment_id'];
+                                break;
+                        }
+                }
+
+                return $previous;
+        }
 }