Changeset 41737 for trunk/tests/phpunit/tests/rest-api/rest-categories-controller.php

Timestamp:

10/04/2017 04:23:33 PM (8 years ago)

Author:

kadamwhite

Message:

REST API: Return 409 status when attempting to create an existing term.

Fixes an issue where submitting a well-formed request to create a term inappropriately returns a 500 error status if that term already exists.
HTTP 5xx error codes should be reserved for unexpected server errors, so "409 Conflict" is a more appropriate response.

Props alibasheer, guzzilar, shooper.
Fixes #41370.

File:

• trunk/tests/phpunit/tests/rest-api/rest-categories-controller.php (modified) (1 diff)

trunk/tests/phpunit/tests/rest-api/rest-categories-controller.php

@@ -603 +603 @@
     }
 
+    /**
+     * @ticket 41370
+     */
+    public function test_create_item_term_already_exists() {
+        wp_set_current_user( self::$administrator );
+        $request = new WP_REST_Request( 'POST', '/wp/v2/categories' );
+        $request->set_param( 'name', 'test' );
+        $response = $this->server->dispatch( $request );
+        $this->assertEquals( 201, $response->get_status() );
+        $response = $this->server->dispatch( $request );
+        $this->assertEquals( 409, $response->get_status() );
+        $data = $response->get_data();
+        $this->assertEquals( 'term_exists', $data['code'] );
+    }
+
     public function test_create_item_invalid_taxonomy() {
         wp_set_current_user( self::$administrator );