Changeset 41755

Timestamp:

10/04/2017 11:42:55 PM (9 years ago)

Author:

pento

Message:

Plugins: Tweak the plugin icons added in [41695].

• Remove plugins icons from the plugin list table, as there were performance issues loading the icons when the site had lots of plugins.
• Depending on which icons the plugin has uploaded, prefer them in this order: svg, 128x128, 256x256.
• Improve the style of the fallback icon for plugins that don't have an icon defined.

Props Travel_girl, danieltj, afercia, karmatosed,hugobaeta, empireoflight, brentjett, melchoyce, pento.
Fixes #30186.

Location:

trunk/src/wp-admin

Files:

• css/list-tables.css (modified) (2 diffs)
• includes/class-wp-plugins-list-table.php (modified) (1 diff)
• update-core.php (modified) (1 diff)

trunk/src/wp-admin/css/list-tables.css

@@ -1289 +1289 @@
 .wp-list-table.plugins .plugin-title,
 .wp-list-table.plugins .theme-title {
+        padding-right: 12px;
         white-space: nowrap;
-}
-
-.wp-list-table.plugins .theme-title {
-        padding-right: 12px;
-}
-
-.wp-list-table.plugins .plugin-title {
-        padding-right: 86px; /* 64 (icon width) + 10 (icon padding) + 12 (title padding) = 86 */
 }
 
@@ -1309 +1302 @@
 
 .plugins .plugin-title .dashicons:before {
-        font-size: 64px;
+        padding: 2px;
+        background-color: #eee;
+        box-shadow: inset 0 0 10px rgba(160,165,170,.15);
+        font-size: 60px;
+        color: #B4B9BE;
 }
 

trunk/src/wp-admin/includes/class-wp-plugins-list-table.php

@@ -752 +752 @@
                                         break;
                                 case 'name':
-                                        $icon = '<span class="dashicons dashicons-admin-plugins"></span>';
-                                        if ( ! empty( $plugin_data['icons']['default'] ) ) {
-                                                $icon = '<img src="' . esc_url( $plugin_data['icons']['default'] ) . '" alt="" />';
-                                        }
-                                        ?>
-                                        <td class="plugin-title column-primary">
-                                                <?php echo $icon; ?>
-                                                <strong><?php echo $plugin_name; ?></strong>
-                                                <?php echo $this->row_actions( $actions, true ); ?>
-                                        </td>
-                                        <?php
+                                        echo "<td class='plugin-title column-primary'><strong>$plugin_name</strong>";
+                                        echo $this->row_actions( $actions, true );
+                                        echo "</td>";
                                         break;
                                 case 'description':

trunk/src/wp-admin/update-core.php

@@ -254 +254 @@
 
                 $icon = '<span class="dashicons dashicons-admin-plugins"></span>';
-                if ( ! empty( $plugin_data->update->icons['default'] ) ) {
-                        $icon = '<img src="' . esc_url( $plugin_data->update->icons['default'] ) . '" alt="" />';
+                $preferred_icons = array( 'svg', '1x', '2x', 'default' );
+                foreach ( $preferred_icons as $preferred_icon ) {
+                        if ( ! empty( $plugin_data->update->icons[ $preferred_icon ] ) ) {
+                                $icon = '<img src="' . esc_url( $plugin_data->update->icons[ $preferred_icon ] ) . '" alt="" />';
+                                break;
+                        }                       
                 }