Changeset 41755 for trunk/src/wp-admin/update-core.php

Timestamp:

10/04/2017 11:42:55 PM (8 years ago)

Author:

pento

Message:

Plugins: Tweak the plugin icons added in [41695].

• Remove plugins icons from the plugin list table, as there were performance issues loading the icons when the site had lots of plugins.
• Depending on which icons the plugin has uploaded, prefer them in this order: svg, 128x128, 256x256.
• Improve the style of the fallback icon for plugins that don't have an icon defined.

Props Travel_girl, danieltj, afercia, karmatosed,hugobaeta, empireoflight, brentjett, melchoyce, pento.
Fixes #30186.

File:

• trunk/src/wp-admin/update-core.php (modified) (1 diff)

trunk/src/wp-admin/update-core.php

@@ -254 +254 @@
 
         $icon = '<span class="dashicons dashicons-admin-plugins"></span>';
-        if ( ! empty( $plugin_data->update->icons['default'] ) ) {
-            $icon = '<img src="' . esc_url( $plugin_data->update->icons['default'] ) . '" alt="" />';
+        $preferred_icons = array( 'svg', '1x', '2x', 'default' );
+        foreach ( $preferred_icons as $preferred_icon ) {
+            if ( ! empty( $plugin_data->update->icons[ $preferred_icon ] ) ) {
+                $icon = '<img src="' . esc_url( $plugin_data->update->icons[ $preferred_icon ] ) . '" alt="" />';
+                break;
+            }           
         }