Changeset 41797 for trunk/src/wp-admin/themes.php

Timestamp:

10/09/2017 04:03:35 PM (7 years ago)

Author:

westonruter

Message:

Customize: Eliminate use of customize-loader in core so Customizer is opened consistently in top window.

• Open the door for future browser history feature in #28536, which is currently not feasible when customize-loader is used.
• Remove customizer-loader from being used on admin screens for Dashboard, Themes, non-shiny theme install/update.
• Keep the customize-loader functionality available for plugins, for the time being. It may become deprecated.
• Ensure return param in customizer links in Themes screen update to reflect search updated by pushState.
• Persist return when reloading Customizer due to theme switch, autosave restoration, or changeset trashing.
• Use location.replace() instead of changing location.href when trashing.
• Hide theme browser while Themes screen is loading when there is a search to prevent flash of unfiltered themes.
• Use throttling instead of debouncing when searching themes to ensure that screen is updated immediately on page load.
• Fix encoding and decoding of search param between URL and search field.
• Add support for dismissing autosaves when closing customize-loader, when it is used by plugins.
• Skip sending changeset UUID to customize-loader for population in browser location if changeset branching is not enabled.

See #28536.
Fixes #40254.

File:

• trunk/src/wp-admin/themes.php (modified) (3 diffs)

trunk/src/wp-admin/themes.php

@@ -147 +147 @@
 wp_enqueue_script( 'theme' );
 wp_enqueue_script( 'updates' );
-wp_enqueue_script( 'customize-loader' );
 
 require_once( ABSPATH . 'wp-admin/admin-header.php' );
@@ -154 +153 @@
 <div class="wrap">
     <h1 class="wp-heading-inline"><?php esc_html_e( 'Themes' ); ?>
-        <span class="title-count theme-count"><?php echo count( $themes ); ?></span>
+        <span class="title-count theme-count"><?php echo ! empty( $_GET['search'] ) ? __( '&hellip;' ) : count( $themes ); ?></span>
     </h1>
 
@@ -235 +234 @@
 ?>
 
-<div class="theme-browser">
+<?php
+$class_name = 'theme-browser';
+if ( ! empty( $_GET['search'] ) ) {
+    $class_name .= ' search-loading';
+}
+?>
+<div class="<?php echo esc_attr( $class_name ); ?>">
     <div class="themes wp-clearfix">