WordPress.org

Make WordPress Core


Ignore:
Timestamp:
10/09/2017 04:03:35 PM (2 years ago)
Author:
westonruter
Message:

Customize: Eliminate use of customize-loader in core so Customizer is opened consistently in top window.

  • Open the door for future browser history feature in #28536, which is currently not feasible when customize-loader is used.
  • Remove customizer-loader from being used on admin screens for Dashboard, Themes, non-shiny theme install/update.
  • Keep the customize-loader functionality available for plugins, for the time being. It may become deprecated.
  • Ensure return param in customizer links in Themes screen update to reflect search updated by pushState.
  • Persist return when reloading Customizer due to theme switch, autosave restoration, or changeset trashing.
  • Use location.replace() instead of changing location.href when trashing.
  • Hide theme browser while Themes screen is loading when there is a search to prevent flash of unfiltered themes.
  • Use throttling instead of debouncing when searching themes to ensure that screen is updated immediately on page load.
  • Fix encoding and decoding of search param between URL and search field.
  • Add support for dismissing autosaves when closing customize-loader, when it is used by plugins.
  • Skip sending changeset UUID to customize-loader for population in browser location if changeset branching is not enabled.

See #28536.
Fixes #40254.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-admin/update.php

    r41289 r41797  
    174174        check_admin_referer('upgrade-theme_' . $theme);
    175175
    176         wp_enqueue_script( 'customize-loader' );
    177176        wp_enqueue_script( 'updates' );
    178177
     
    224223        $api = themes_api('theme_information', array('slug' => $theme, 'fields' => array('sections' => false, 'tags' => false) ) ); //Save on a bit of bandwidth.
    225224
    226         if ( is_wp_error($api) )
    227             wp_die($api);
    228 
    229         wp_enqueue_script( 'customize-loader' );
     225        if ( is_wp_error( $api ) ) {
     226            wp_die( $api );
     227        }
    230228
    231229        $title = __('Install Themes');
     
    253251
    254252        $file_upload = new File_Upload_Upgrader('themezip', 'package');
    255 
    256         wp_enqueue_script( 'customize-loader' );
    257253
    258254        $title = __('Upload Theme');
Note: See TracChangeset for help on using the changeset viewer.