Changeset 41836

Timestamp:

10/12/2017 03:47:29 AM (7 years ago)

Author:

melchoyce

Message:

Settings: Widen image size input fields on Media Settings page.

On narrower devices, input fields are too short to fit the number of default digits they contain. This widens the fields and also breaks each height and width attribute onto a new line for better usability, using some terrible CSS trickery. My apologies.

Props: Toru, Presskopp, desrosj, xkon, ryelle, melchoyce.
Fixes #34539.

Location:

trunk/src/wp-admin

Files:

• css/common.css (modified) (1 diff)
• css/forms.css (modified) (1 diff)
• options-media.php (modified) (3 diffs)

trunk/src/wp-admin/css/common.css

@@ -3717 +3717 @@
 }
 
+.options-media-php br {
+    display: none;
+}
+
+@media screen and (max-width: 375px) {
+    .options-media-php input[type="number"][name*="_size_"] {
+        margin: 5px 0;
+    }
+    .options-media-php label[for*="_size_h"]:before {
+        content: '';
+        display: block;
+    }
+    .options-media-php br {
+        display: block;
+    }
+}
+
 @media screen and (max-width: 320px) {
     /* Prevent default center alignment and larger font for the Right Now widget when

trunk/src/wp-admin/css/forms.css

@@ -1221 +1221 @@
     .form-table input[type="text"].small-text {
         width: auto;
-        max-width: 55px;
+        max-width: 4.375em; /* 70px, enough for 4 digits to fit comfortably */
         display: inline;
         padding: 3px 6px;

trunk/src/wp-admin/options-media.php

@@ -56 +56 @@
 <input name="thumbnail_size_w" type="number" step="1" min="0" id="thumbnail_size_w" value="<?php form_option('thumbnail_size_w'); ?>" class="small-text" />
 <label for="thumbnail_size_h"><?php _e('Height'); ?></label>
-<input name="thumbnail_size_h" type="number" step="1" min="0" id="thumbnail_size_h" value="<?php form_option('thumbnail_size_h'); ?>" class="small-text" /><br />
-<input name="thumbnail_crop" type="checkbox" id="thumbnail_crop" value="1" <?php checked('1', get_option('thumbnail_crop')); ?>/>
-<label for="thumbnail_crop"><?php _e('Crop thumbnail to exact dimensions (normally thumbnails are proportional)'); ?></label>
+<input name="thumbnail_size_h" type="number" step="1" min="0" id="thumbnail_size_h" value="<?php form_option('thumbnail_size_h'); ?>" class="small-text" />
+<p><input name="thumbnail_crop" type="checkbox" id="thumbnail_crop" value="1" <?php checked('1', get_option('thumbnail_crop')); ?>/>
+<label for="thumbnail_crop"><?php _e('Crop thumbnail to exact dimensions (normally thumbnails are proportional)'); ?></label></p>
 </td>
 </tr>
@@ -67 +67 @@
 <label for="medium_size_w"><?php _e('Max Width'); ?></label>
 <input name="medium_size_w" type="number" step="1" min="0" id="medium_size_w" value="<?php form_option('medium_size_w'); ?>" class="small-text" />
+<br />
 <label for="medium_size_h"><?php _e('Max Height'); ?></label>
 <input name="medium_size_h" type="number" step="1" min="0" id="medium_size_h" value="<?php form_option('medium_size_h'); ?>" class="small-text" />
@@ -77 +78 @@
 <label for="large_size_w"><?php _e('Max Width'); ?></label>
 <input name="large_size_w" type="number" step="1" min="0" id="large_size_w" value="<?php form_option('large_size_w'); ?>" class="small-text" />
+<br />
 <label for="large_size_h"><?php _e('Max Height'); ?></label>
 <input name="large_size_h" type="number" step="1" min="0" id="large_size_h" value="<?php form_option('large_size_h'); ?>" class="small-text" />