Changeset 41848 for trunk/src/wp-includes/comment.php

Timestamp:

10/12/2017 02:58:58 PM (8 years ago)

Author:

boonebgorges

Message:

Invalidate comment query cache when modifying comment meta.

Comment queries are sensitive to comment meta due to the meta_query
parameter, so the cache must be invalidated when comment meta is changed,
added, or deleted.

Props spacedmonkey.
See #40669.

File:

• trunk/src/wp-includes/comment.php (modified) (3 diffs)

trunk/src/wp-includes/comment.php

@@ -424 +424 @@
  */
 function add_comment_meta($comment_id, $meta_key, $meta_value, $unique = false) {
-    return add_metadata('comment', $comment_id, $meta_key, $meta_value, $unique);
+    $added = add_metadata( 'comment', $comment_id, $meta_key, $meta_value, $unique );
+    if ( $added ) {
+        wp_cache_set( 'last_changed', microtime(), 'comment' );
+    }
+    return $added;
 }
 
@@ -443 +447 @@
  */
 function delete_comment_meta($comment_id, $meta_key, $meta_value = '') {
-    return delete_metadata('comment', $comment_id, $meta_key, $meta_value);
+    $deleted = delete_metadata( 'comment', $comment_id, $meta_key, $meta_value );
+    if ( $deleted ) {
+        wp_cache_set( 'last_changed', microtime(), 'comment' );
+    }
+    return $deleted;
 }
 
@@ -480 +488 @@
  */
 function update_comment_meta($comment_id, $meta_key, $meta_value, $prev_value = '') {
-    return update_metadata('comment', $comment_id, $meta_key, $meta_value, $prev_value);
+    $updated = update_metadata( 'comment', $comment_id, $meta_key, $meta_value, $prev_value );
+    if ( $updated ) {
+        wp_cache_set( 'last_changed', microtime(), 'comment' );
+    }
+    return $updated;
 }