Changeset 41849

Timestamp:

10/12/2017 03:19:30 PM (7 years ago)

Author:

boonebgorges

Message:

Bump 'posts' query cache incrementor when modifying postmeta.

This ensures that the get_pages() query cache doesn't go stale when
postmeta is modified.

Props spacedmonkey.
Fixes #40669.

Location:

trunk

Files:

• src/wp-includes/post.php (modified) (4 diffs)
• tests/phpunit/tests/post/getPages.php (modified) (1 diff)

trunk/src/wp-includes/post.php

@@ -1729 +1729 @@
         $post_id = $the_post;
 
-    return add_metadata('post', $post_id, $meta_key, $meta_value, $unique);
+    $added = add_metadata( 'post', $post_id, $meta_key, $meta_value, $unique );
+    if ( $added ) {
+        wp_cache_set( 'last_changed', microtime(), 'posts' );
+    }
+    return $added;
 }
 
@@ -1752 +1756 @@
         $post_id = $the_post;
 
-    return delete_metadata('post', $post_id, $meta_key, $meta_value);
+    $deleted = delete_metadata( 'post', $post_id, $meta_key, $meta_value );
+    if ( $deleted ) {
+        wp_cache_set( 'last_changed', microtime(), 'posts' );
+    }
+    return $deleted;
 }
 
@@ -1794 +1802 @@
         $post_id = $the_post;
 
-    return update_metadata('post', $post_id, $meta_key, $meta_value, $prev_value);
+    $updated = update_metadata( 'post', $post_id, $meta_key, $meta_value, $prev_value );
+    if ( $updated ) {
+        wp_cache_set( 'last_changed', microtime(), 'posts' );
+    }
+    return $updated;
 }
 
@@ -1806 +1818 @@
  */
 function delete_post_meta_by_key( $post_meta_key ) {
-    return delete_metadata( 'post', null, $post_meta_key, '', true );
+    $deleted = delete_metadata( 'post', null, $post_meta_key, '', true );
+    if ( $deleted ) {
+        wp_cache_set( 'last_changed', microtime(), 'posts' );
+    }
+    return $deleted;
 }
 

trunk/tests/phpunit/tests/post/getPages.php

@@ -97 +97 @@
 
     /**
+     * @ticket 40669
+     */
+    public function test_cache_should_be_invalidated_by_add_post_meta() {
+        $posts = self::factory()->post->create_many( 2, array(
+            'post_type' => 'page',
+        ) );
+
+        add_post_meta( $posts[0], 'foo', 'bar' );
+
+        $cached = get_pages( array(
+            'meta_key' => 'foo',
+            'meta_value' => 'bar',
+        ) );
+
+        $cached_ids = wp_list_pluck( $cached, 'ID' );
+        $this->assertEqualSets( array( $posts[0] ), $cached_ids );
+
+        add_post_meta( $posts[1], 'foo', 'bar' );
+
+        $found = get_pages( array(
+            'meta_key' => 'foo',
+            'meta_value' => 'bar',
+        ) );
+
+        $found_ids = wp_list_pluck( $found, 'ID' );
+        $this->assertEqualSets( $posts, $found_ids );
+    }
+
+    /**
+     * @ticket 40669
+     */
+    public function test_cache_should_be_invalidated_by_update_post_meta() {
+        $posts = self::factory()->post->create_many( 2, array(
+            'post_type' => 'page',
+        ) );
+
+        add_post_meta( $posts[0], 'foo', 'bar' );
+        add_post_meta( $posts[1], 'foo', 'bar' );
+
+        $cached = get_pages( array(
+            'meta_key' => 'foo',
+            'meta_value' => 'bar',
+        ) );
+
+        $cached_ids = wp_list_pluck( $cached, 'ID' );
+        $this->assertEqualSets( $posts, $cached_ids );
+
+        update_post_meta( $posts[1], 'foo', 'baz' );
+
+        $found = get_pages( array(
+            'meta_key' => 'foo',
+            'meta_value' => 'bar',
+        ) );
+
+        $found_ids = wp_list_pluck( $found, 'ID' );
+        $this->assertEqualSets( array( $posts[0] ), $found_ids );
+    }
+
+    /**
+     * @ticket 40669
+     */
+    public function test_cache_should_be_invalidated_by_delete_post_meta() {
+        $posts = self::factory()->post->create_many( 2, array(
+            'post_type' => 'page',
+        ) );
+
+        add_post_meta( $posts[0], 'foo', 'bar' );
+        add_post_meta( $posts[1], 'foo', 'bar' );
+
+        $cached = get_pages( array(
+            'meta_key' => 'foo',
+            'meta_value' => 'bar',
+        ) );
+
+        $cached_ids = wp_list_pluck( $cached, 'ID' );
+        $this->assertEqualSets( $posts, $cached_ids );
+
+        delete_post_meta( $posts[1], 'foo' );
+
+        $found = get_pages( array(
+            'meta_key' => 'foo',
+            'meta_value' => 'bar',
+        ) );
+
+        $found_ids = wp_list_pluck( $found, 'ID' );
+        $this->assertEqualSets( array( $posts[0] ), $found_ids );
+    }
+
+    /**
+     * @ticket 40669
+     */
+    public function test_cache_should_be_invalidated_by_delete_post_meta_by_key() {
+        $posts = self::factory()->post->create_many( 2, array(
+            'post_type' => 'page',
+        ) );
+
+        add_post_meta( $posts[0], 'foo', 'bar' );
+        add_post_meta( $posts[1], 'foo', 'bar' );
+
+        $cached = get_pages( array(
+            'meta_key' => 'foo',
+            'meta_value' => 'bar',
+        ) );
+
+        $cached_ids = wp_list_pluck( $cached, 'ID' );
+        $this->assertEqualSets( $posts, $cached_ids );
+
+        delete_post_meta_by_key( 'foo' );
+
+        $found = get_pages( array(
+            'meta_key' => 'foo',
+            'meta_value' => 'bar',
+        ) );
+
+        $found_ids = wp_list_pluck( $found, 'ID' );
+        $this->assertEqualSets( array(), $found_ids );
+    }
+
+    /**
      * @ticket 20376
      */