Changeset 41867 for trunk/src/wp-includes/widgets/class-wp-widget-categories.php

Timestamp:

10/15/2017 09:42:52 PM (8 years ago)

Author:

SergeyBiryukov

Message:

Widgets: Move empty title checks out of the apply_filters( 'widget_title' ) calls for clarity.

See #42226.

File:

• trunk/src/wp-includes/widgets/class-wp-widget-categories.php (modified) (2 diffs)

trunk/src/wp-includes/widgets/class-wp-widget-categories.php

@@ -45 +45 @@
         static $first_dropdown = true;
 
+        $title = ! empty( $instance['title'] ) ? $instance['title'] : __( 'Categories' );
+
         /** This filter is documented in wp-includes/widgets/class-wp-widget-pages.php */
-        $title = apply_filters( 'widget_title', empty( $instance['title'] ) ? __( 'Categories' ) : $instance['title'], $instance, $this->id_base );
+        $title = apply_filters( 'widget_title', $title, $instance, $this->id_base );
 
         $c = ! empty( $instance['count'] ) ? '1' : '0';
@@ -53 +55 @@
 
         echo $args['before_widget'];
+
         if ( $title ) {
             echo $args['before_title'] . $title . $args['after_title'];