Changeset 41887 for trunk/tests/phpunit/tests/customize/nav-menus.php

Timestamp:

10/17/2017 08:14:56 PM (7 years ago)

Author:

westonruter

Message:

Customize: Allow post/page stubs to be edited in WP Admin as "customization drafts" when changeset is saved as draft or scheduled.

• Update stubs to have draft status when changeset is saved as draft, instead of preventing auto-draft garbage collection by giving them a far-future post_date.
• Show notice in publish metabox when editing a customization draft indicating that it will be published automatically with its changeset; a link to Customizer is included.
• Include a new "Customization Draft" display post state in the post list table.
• Disconnect stubs from their changesets when they are updated with a status other than "Draft".
• Trash customization drafts when their related changeset is trashed or deleted.
• Add a _customize_changeset_uuid postmeta to stubs to link them with their associated changeset.
• Include customize_changeset_uuid as context when requesting to insert a new auto-draft.

Props westonruter, melchoyce.
See #39896, #39752, #34923.
Fixes #42220.

File:

• trunk/tests/phpunit/tests/customize/nav-menus.php (modified) (10 diffs)

trunk/tests/phpunit/tests/customize/nav-menus.php

@@ -542 +542 @@
         $r = $menus->insert_auto_draft_post( array( 'post_title' => 'Non-existent', 'post_type' => 'nonexistent' ) );
         $this->assertInstanceOf( 'WP_Post', $r );
+        $this->assertEquals( $this->wp_customize->changeset_uuid(), get_post_meta( $r->ID, '_customize_changeset_uuid', true ) );
 
         $r = $menus->insert_auto_draft_post( array( 'post_type' => 'post' ) );
@@ -556 +557 @@
         $this->assertEquals( '', $r->post_name );
         $this->assertEquals( 'hello-world', get_post_meta( $r->ID, '_customize_draft_post_name', true ) );
+        $this->assertEquals( $this->wp_customize->changeset_uuid(), get_post_meta( $r->ID, '_customize_changeset_uuid', true ) );
         $this->assertEquals( 'post', $r->post_type );
 
@@ -564 +566 @@
         $this->assertEquals( '', $r->post_name );
         $this->assertEquals( 'greetings-world', get_post_meta( $r->ID, '_customize_draft_post_name', true ) );
+        $this->assertEquals( $this->wp_customize->changeset_uuid(), get_post_meta( $r->ID, '_customize_changeset_uuid', true ) );
         $this->assertEquals( 'Hi World', $r->post_content );
     }
@@ -717 +720 @@
         ) );
 
+        $draft_post_id = $this->factory()->post->create( array(
+            'post_status' => 'draft',
+            'post_title' => 'Draft',
+            'post_author' => $administrator_user_id,
+        ) );
+
+        $private_post_id = $this->factory()->post->create( array(
+            'post_status' => 'private',
+            'post_title' => 'Private',
+            'post_author' => $administrator_user_id,
+        ) );
+
         $value = array(
             'bad',
@@ -722 +737 @@
             $author_post_id,
             $administrator_post_id,
+            $draft_post_id,
+            $private_post_id,
         );
 
@@ -734 +751 @@
         wp_set_current_user( $administrator_user_id );
         $sanitized = $menus->sanitize_nav_menus_created_posts( $value );
-        $this->assertEquals( array( $contributor_post_id, $author_post_id, $administrator_post_id ), $sanitized );
+        $this->assertEquals( array( $contributor_post_id, $author_post_id, $administrator_post_id, $draft_post_id ), $sanitized );
     }
 
@@ -747 +764 @@
 
         $post_ids = array();
-        for ( $i = 0; $i < 3; $i += 1 ) {
-            $r = $menus->insert_auto_draft_post( array(
-                'post_title' => 'Auto Draft ' . $i,
-                'post_type' => 'post',
-                'post_name' => 'auto-draft-' . $i,
-            ) );
-            $this->assertInstanceOf( 'WP_Post', $r );
-            $post_ids[] = $r->ID;
-        }
+
+        // Auto-draft.
+        $r = $menus->insert_auto_draft_post( array(
+            'post_title' => 'Auto Draft',
+            'post_type' => 'post',
+            'post_name' => 'auto-draft-1',
+        ) );
+        $this->assertInstanceOf( 'WP_Post', $r );
+        $post_ids[] = $r->ID;
+
+        // Draft.
+        $r = $menus->insert_auto_draft_post( array(
+            'post_title' => 'Draft',
+            'post_type' => 'post',
+            'post_name' => 'auto-draft-2',
+        ) );
+        $this->assertInstanceOf( 'WP_Post', $r );
+        wp_update_post( array(
+            'ID' => $r->ID,
+            'post_status' => 'draft',
+        ) );
+        $post_ids[] = $r->ID;
+
+        $drafted_post_ids = $post_ids;
+
+        // Private (this will exclude it from being considered a stub).
+        $r = $menus->insert_auto_draft_post( array(
+            'post_title' => 'Private',
+            'post_type' => 'post',
+            'post_name' => 'auto-draft-3',
+        ) );
+        $this->assertInstanceOf( 'WP_Post', $r );
+        wp_update_post( array(
+            'ID' => $r->ID,
+            'post_status' => 'private',
+        ) );
+        $post_ids[] = $r->ID;
+        $private_post_id = $r->ID;
+
+        // Trashed (this will exclude it from being considered a stub).
+        $r = $menus->insert_auto_draft_post( array(
+            'post_title' => 'Trash',
+            'post_type' => 'post',
+            'post_name' => 'auto-draft-4',
+        ) );
+        $this->assertInstanceOf( 'WP_Post', $r );
+        wp_trash_post( $r->ID );
+        $post_ids[] = $r->ID;
+        $trashed_post_id = $r->ID;
 
         $pre_published_post_id = $this->factory()->post->create( array( 'post_status' => 'publish' ) );
@@ -764 +821 @@
         $this->assertInstanceOf( 'WP_Customize_Filter_Setting', $setting );
         $this->assertEquals( array( $menus, 'sanitize_nav_menus_created_posts' ), $setting->sanitize_callback );
-        $this->assertEquals( $post_ids, $setting->post_value() );
-        foreach ( $post_ids as $post_id ) {
-            $this->assertEquals( 'auto-draft', get_post_status( $post_id ) );
+        $this->assertEquals( $drafted_post_ids, $setting->post_value() );
+        $this->assertArrayNotHasKey( $private_post_id, $post_ids );
+        $this->assertArrayNotHasKey( $trashed_post_id, $post_ids );
+
+        $this->assertEquals( 'auto-draft', get_post_status( $drafted_post_ids[0] ) );
+        $this->assertEquals( 'draft', get_post_status( $drafted_post_ids[1] ) );
+        foreach ( $drafted_post_ids as $post_id ) {
             $this->assertEmpty( get_post( $post_id )->post_name );
             $this->assertNotEmpty( get_post_meta( $post_id, '_customize_draft_post_name', true ) );
@@ -774 +835 @@
         $setting->save();
         $this->assertEquals( $save_action_count + 1, did_action( 'customize_save_nav_menus_created_posts' ) );
-        foreach ( $post_ids as $post_id ) {
+        foreach ( $drafted_post_ids as $post_id ) {
             $this->assertEquals( 'publish', get_post_status( $post_id ) );
             $this->assertRegExp( '/^auto-draft-\d+$/', get_post( $post_id )->post_name );
@@ -780 +841 @@
         }
 
+        $this->assertEquals( 'private', get_post_status( $private_post_id ) );
+        $this->assertEquals( 'trash', get_post_status( $trashed_post_id ) );
+
         // Ensure that unique slugs were assigned.
-        $posts = array_map( 'get_post', $post_ids );
+        $posts = array_map( 'get_post', $drafted_post_ids );
         $post_names = wp_list_pluck( $posts, 'post_name' );
         $this->assertEqualSets( $post_names, array_unique( $post_names ) );