Changeset 41913

Timestamp:

10/18/2017 05:39:46 PM (7 years ago)

Author:

westonruter

Message:

Widgets: Fix previewing embeds in Text widget by allowing parse-embed admin ajax requests with an empty post_ID just as WP_oEmbed_Controller::get_proxy_item_permissions_check() allows.

As of #34115 if there is no post context the oEmbed will be cached in an oembed_cache custom post type, so having a post as context is no longer a requirement for caching.

Props biskobe, westonruter.
See #34115, #40450.
Fixes #40854.

File:

• trunk/src/wp-admin/includes/ajax-actions.php (modified) (2 diffs)

trunk/src/wp-admin/includes/ajax-actions.php

@@ -3006 +3006 @@
     global $post, $wp_embed;
 
-    if ( ! $post = get_post( (int) $_POST['post_ID'] ) ) {
-        wp_send_json_error();
-    }
-
-    if ( empty( $_POST['shortcode'] ) || ! current_user_can( 'edit_post', $post->ID ) ) {
+    if ( empty( $_POST['shortcode'] ) ) {
+        wp_send_json_error();
+    }
+    $post_id = isset( $_POST[ 'post_ID' ] ) ? intval( $_POST[ 'post_ID' ] ) : 0;
+    if ( $post_id > 0 ) {
+        $post = get_post( $post_id );
+        if ( ! $post || ! current_user_can( 'edit_post', $post->ID ) ) {
+            wp_send_json_error();
+        }
+        setup_postdata( $post );
+    } elseif ( ! current_user_can( 'edit_posts' ) ) { // See WP_oEmbed_Controller::get_proxy_item_permissions_check().
         wp_send_json_error();
     }
@@ -3027 +3033 @@
 
     $parsed = false;
-    setup_postdata( $post );
-
     $wp_embed->return_false_on_fail = true;