Changeset 41937 for trunk/src/wp-admin/custom-header.php

Timestamp:

10/19/2017 04:17:31 AM (8 years ago)

Author:

joemcgill

Message:

Customizer: Improve handling of crops in the media library.

This is a follow up on r41732, implementing the following improvements:

• Attachment parent info is now stored in attachment meta rather than a

separate post meta key.

• Attachments created from contextual crops (e.g. header, logos, etc.) are

filtered out of the media library using a new _filterContext method in
wp.media.controller.Library.

Props joemcgill, westonruter.
See #21819.

File:

• trunk/src/wp-admin/custom-header.php (modified) (2 diffs)

trunk/src/wp-admin/custom-header.php

@@ -1188 +1188 @@
         $metadata = wp_generate_attachment_metadata( $attachment_id, $cropped );
 
+        // If this is a crop, save the original attachment ID as metadata.
+        if ( $parent_id ) {
+            $metadata['attachment_parent'] = $parent_id;
+        }
+
         /**
          * Filters the header image attachment metadata.
@@ -1198 +1203 @@
          */
         $metadata = apply_filters( 'wp_header_image_attachment_metadata', $metadata );
+
         wp_update_attachment_metadata( $attachment_id, $metadata );
-
-        if ( $parent_id ) {
-            $meta = add_post_meta( $attachment_id, '_wp_attachment_parent', $parent_id, true );
-        }
 
         return $attachment_id;