WordPress.org

Make WordPress Core

Changeset 41973


Ignore:
Timestamp:
10/23/17 18:57:46 (5 weeks ago)
Author:
obenland
Message:

Customize: Ease extendability of filter drawer

By moving the wporg conditional inside the method body, the filter drawer can be overridden without having to also override the entire section template.

Props celloexpressions.
Closes #42212.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-includes/customize/class-wp-customize-themes-section.php

    r41903 r41973  
    8181                        <?php $this->filter_bar_content_template(); ?> 
    8282                    </div> 
    83                     <# if ( 'wporg' === data.action ) { #> 
    84                         <?php $this->filter_drawer_content_template(); ?> 
    85                     <# } #> 
     83                    <?php $this->filter_drawer_content_template(); ?> 
    8684                    <div class="error unexpected-error" style="display: none; "><p><?php _e( 'An unexpected error occurred. Something may be wrong with WordPress.org or this server&#8217;s configuration. If you continue to have problems, please try the <a href="https://wordpress.org/support/">support forums</a>.' ); ?></p></div> 
    8785                    <ul class="themes"> 
     
    151149     * Render the filter drawer portion of a themes section as a JS template. 
    152150     * 
    153      * The template is only rendered by PHP once, so all actions are prepared at once on the server side. 
    154151     * The filter bar container is rendered by @see `render_template()`. 
    155152     * 
     
    159156        $feature_list = get_theme_feature_list( false ); // @todo: Use the .org API instead of the local core feature list. The .org API is currently outdated and will be reconciled when the .org themes directory is next redesigned. 
    160157        ?> 
    161         <div class="filter-drawer filter-details"> 
    162             <?php foreach ( $feature_list as $feature_name => $features ) : ?> 
    163                 <fieldset class="filter-group"> 
    164                     <legend><?php echo esc_html( $feature_name ); ?></legend> 
    165                     <div class="filter-group-feature"> 
    166                         <?php foreach ( $features as $feature => $feature_name ) : ?> 
    167                             <input type="checkbox" id="filter-id-<?php echo esc_attr( $feature ); ?>" value="<?php echo esc_attr( $feature ); ?>" /> 
    168                             <label for="filter-id-<?php echo esc_attr( $feature ); ?>"><?php echo esc_html( $feature_name ); ?></label><br> 
    169                         <?php endforeach; ?> 
    170                     </div> 
    171                 </fieldset> 
    172             <?php endforeach; ?> 
    173         </div> 
     158        <# if ( 'wporg' === data.action ) { #> 
     159            <div class="filter-drawer filter-details"> 
     160                <?php foreach ( $feature_list as $feature_name => $features ) : ?> 
     161                    <fieldset class="filter-group"> 
     162                        <legend><?php echo esc_html( $feature_name ); ?></legend> 
     163                        <div class="filter-group-feature"> 
     164                            <?php foreach ( $features as $feature => $feature_name ) : ?> 
     165                                <input type="checkbox" id="filter-id-<?php echo esc_attr( $feature ); ?>" value="<?php echo esc_attr( $feature ); ?>" /> 
     166                                <label for="filter-id-<?php echo esc_attr( $feature ); ?>"><?php echo esc_html( $feature_name ); ?></label><br> 
     167                            <?php endforeach; ?> 
     168                        </div> 
     169                    </fieldset> 
     170                <?php endforeach; ?> 
     171            </div> 
     172        <# } #> 
    174173        <?php 
    175174    } 
Note: See TracChangeset for help on using the changeset viewer.