Changeset 42009 for trunk/src/wp-admin/includes/ajax-actions.php

Timestamp:

10/24/2017 11:09:43 PM (23 months ago)

Author:

westonruter

Message:

Embeds: Improve consistency of update and refresh logic for oEmbed caching between oembed_cache and post meta.

• Allow updating oEmbed cache during parse-embed requests for non-post editors (such as widgets).
• Update any existing oembed_cache post when usecache and TTL has passed.
• Do not overwrite a previously valid cache with {{unknown}}.

Props dlh.
See #34115.
Fixes #42310.

File:

• trunk/src/wp-admin/includes/ajax-actions.php (modified) (1 diff)

trunk/src/wp-admin/includes/ajax-actions.php

@@ -3028 +3028 @@
     $wp_embed->return_false_on_fail = true;
 
+    if ( 0 === $post_id ) {
+        /*
+         * Refresh oEmbeds cached outside of posts that are past their TTL.
+         * Posts are excluded because they have separate logic for refreshing
+         * their post meta caches. See WP_Embed::cache_oembed().
+         */
+        $wp_embed->usecache = false;
+    }
+
     if ( is_ssl() && 0 === strpos( $url, 'http://' ) ) {
         // Admin is ssl and the user pasted non-ssl URL.