Changeset 42009 for trunk/tests/phpunit/tests/oembed/WpEmbed.php

Timestamp:

10/24/2017 11:09:43 PM (23 months ago)

Author:

westonruter

Message:

Embeds: Improve consistency of update and refresh logic for oEmbed caching between oembed_cache and post meta.

• Allow updating oEmbed cache during parse-embed requests for non-post editors (such as widgets).
• Update any existing oembed_cache post when usecache and TTL has passed.
• Do not overwrite a previously valid cache with {{unknown}}.

Props dlh.
See #34115.
Fixes #42310.

File:

• trunk/tests/phpunit/tests/oembed/WpEmbed.php (modified) (1 diff)

trunk/tests/phpunit/tests/oembed/WpEmbed.php

@@ -273 +273 @@
     }
 
+    /**
+     * Test that parsing an embed shortcode should cause oembed_cache to be updated.
+     *
+     * @ticket 42310
+     */
+    public function test_shortcode_should_update_custom_post() {
+        add_filter( 'oembed_ttl', '__return_zero' );
+
+        $url        = 'https://example.com/';
+        $embedded   = '<b>Embedded content</b>';
+        $key_suffix = md5( $url . serialize( wp_embed_defaults( $url ) ) );
+
+        add_filter( 'pre_oembed_result', '__return_empty_string' );
+        $this->wp_embed->shortcode( array(), $url );
+        remove_filter( 'pre_oembed_result', '__return_empty_string' );
+
+        $oembed_post_id = $this->wp_embed->find_oembed_post_id( $key_suffix );
+
+        $this->assertSame( '{{unknown}}', get_post( $oembed_post_id )->post_content );
+
+        $previous_usecache = $this->wp_embed->usecache;
+        $this->wp_embed->usecache = false;
+
+        // The update cannot be empty because empty responses won't overwrite the cache.
+        add_filter( 'pre_oembed_result', array( $this, '_pre_oembed_result_callback' ) );
+        $this->wp_embed->shortcode( array(), $url );
+        remove_filter( 'pre_oembed_result', array( $this, '_pre_oembed_result_callback' ) );
+
+        $this->assertSame( $embedded, get_post( $oembed_post_id )->post_content );
+
+        $this->wp_embed->usecache = $previous_usecache;
+        remove_filter( 'oembed_ttl', '__return_zero' );
+    }
+
     public function test_shortcode_should_get_url_from_src_attribute() {
         $url    = 'http://example.com/embed/foo';