Changeset 42012

Timestamp:

10/24/2017 11:26:38 PM (6 years ago)

Author:

westonruter

Message:

Permalinks: Fix placement of structure tags based on last cursor position.

Props felipeelia, afercia.
See #29872.
Fixes #42042.

File:

• trunk/src/wp-admin/js/common.js (modified) (2 diffs)

trunk/src/wp-admin/js/common.js

@@ -248 +248 @@
         selectionEnd            = $permalinkStructure[ 0 ].selectionEnd,
         textToAppend            = $( this ).text().trim(),
-        textToAnnounce          = $( this ).attr( 'data-added' );
+        textToAnnounce          = $( this ).attr( 'data-added' ),
+        newSelectionStart;
 
     // Remove structure tag if already part of the structure.
@@ -289 +290 @@
     // Disable button.
     changeStructureTagButtonState( $( this ) );
+
+    // If input had focus give it back with cursor right after appended text.
+    if ( permalinkStructureFocused && $permalinkStructure[0].setSelectionRange ) {
+        newSelectionStart = ( permalinkStructureValue.substr( 0, selectionStart ) + textToAppend ).length;
+        $permalinkStructure[0].setSelectionRange( newSelectionStart, newSelectionStart );
+        $permalinkStructure.focus();
+    }
 } );