Changeset 42029

Timestamp:

10/27/2017 03:30:27 AM (9 years ago)

Author:

westonruter

Message:

Themes: Switch back from throttling to debouncing in theme searches on admin screen.

Start debouncing after initial search performed when search query param is present to prevent initial "flash of unsearched themes".

Props afercia, westonruter.
Amends [41797].
See #40254.
Fixes #42348.

File:

• trunk/src/wp-admin/js/theme.js (modified) (7 diffs)

trunk/src/wp-admin/js/theme.js

@@ -103 +103 @@
                         parent: this
                 });
+                self.searchView = view;
 
                 // Render and append after screen title
@@ -1348 +1349 @@
                 }
 
-                // Note that doSearch is throttled.
+                // Since doSearch is debounced, it will only run when user input comes to a rest.
                 this.doSearch( event );
         },
 
         // Runs a search on the theme collection.
-        doSearch: _.throttle( function( event ) {
+        doSearch: function( event ) {
                 var options = {};
 
@@ -1371 +1372 @@
                         themes.router.navigate( themes.router.baseUrl( '' ) );
                 }
-        }, 500 ),
+        },
 
         pushState: function( event ) {
@@ -1446 +1447 @@
 
                 this.render();
+
+                // Start debouncing user searches after Backbone.history.start().
+                this.view.searchView.doSearch = _.debounce( this.view.searchView.doSearch, 500 );
         },
 
@@ -1521 +1525 @@
         },
 
-        doSearch: _.throttle( function( value ) {
+        doSearch: function( value ) {
                 var request = {};
 
@@ -1565 +1569 @@
                 // Set route
                 themes.router.navigate( themes.router.baseUrl( themes.router.searchPath + encodeURIComponent( value ) ), { replace: true } );
-        }, 500 )
+        }
 });
 
@@ -1920 +1924 @@
                 this.render();
 
+                // Start debouncing user searches after Backbone.history.start().
+                this.view.searchView.doSearch = _.debounce( this.view.searchView.doSearch, 500 );
         },