Changeset 42042 for trunk/src/wp-includes/customize/class-wp-customize-date-time-control.php

Timestamp:

10/30/2017 04:39:06 PM (7 years ago)

Author:

westonruter

Message:

Customize: Allow 0:00-0:59 in date/time control when 24-hour time used.

• Let min hour be 0 and max be 23 in 24-hour time; let min hour be 1 and max be 12 in 12-hour time.
• Show error notification when an invalid date value is provided, not just when not a future date.
• Fix translation of custom validity message.
• Start checking for validity after all inputs have been initially populated.
• Remove support for being able to enter 24:00.
• Cease forcing date input elements from being casted to integers, to allow for invalid inputs to be detected.

Props westonruter, Presskopp, peterwilsoncc, atachibana for testing.
See #39896, #28721.
Fixes #42373.

File:

• trunk/src/wp-includes/customize/class-wp-customize-date-time-control.php (modified) (1 diff)

trunk/src/wp-includes/customize/class-wp-customize-date-time-control.php

@@ -142 +142 @@
                     <div class="time-fields clear">
                         <label for="{{ idPrefix }}date-time-hour" class="screen-reader-text"><?php esc_html_e( 'Hour' ); ?></label>
-                        <# var maxHour = data.twelveHourFormat ? 12 : 24; #>
-                        <input id="{{ idPrefix }}date-time-hour" type="number" size="2" autocomplete="off" class="date-input hour" data-component="hour" min="1" max="{{ maxHour }}">
+                        <# var maxHour = data.twelveHourFormat ? 12 : 23; #>
+                        <# var minHour = data.twelveHourFormat ? 1 : 0; #>
+                        <input id="{{ idPrefix }}date-time-hour" type="number" size="2" autocomplete="off" class="date-input hour" data-component="hour" min="{{ minHour }}" max="{{ maxHour }}">
                         <span class="time-special-char date-time-separator">:</span>
                         <label for="{{ idPrefix }}date-time-minute" class="screen-reader-text"><?php esc_html_e( 'Minute' ); ?></label>