Changeset 42055

Timestamp:

10/31/2017 09:13:09 AM (6 years ago)

Author:

pento

Message:

Build/Test Tools: Pass correct $message argument to WP_UnitTestCase::setExpectedException() in Tests_Ajax_CompressionTest::test_logged_out() and Tests_Ajax_TagSearch::test_no_results().

PHPUnit 6.4.1 and earlier versions ignored the '0' value, causing the issue to go unnoticed.

Merge of [41870] to the 4.4 branch.

Props SergeyBiryukov.
Fixes #42232.

Location:

branches/4.4

Files:

• . (modified) (1 prop)
• tests/phpunit/tests/ajax/Compression.php (modified) (1 diff)
• tests/phpunit/tests/ajax/TagSearch.php (modified) (1 diff)

branches/4.4/tests/phpunit/tests/ajax/Compression.php

@@ -26 +26 @@
 
         // Make the request
-        $this->setExpectedException( 'WPAjaxDieStopException', '0' );
+        $this->setExpectedException( 'WPAjaxDieStopException', '-1' );
         $this->_handleAjax( 'wp-compression-test' );
     }

branches/4.4/tests/phpunit/tests/ajax/TagSearch.php

@@ -75 +75 @@
         // Make the request
         // No output, so we get a stop exception
-        $this->setExpectedException( 'WPAjaxDieStopException', '0' );
+        $this->setExpectedException( 'WPAjaxDieStopException', '' );
         $this->_handleAjax( 'ajax-tag-search' );
     }