Changeset 42056 for trunk/src/wp-includes/meta.php

Timestamp:

10/31/2017 11:59:43 AM (8 years ago)

Author:

pento

Message:

Database: Restore numbered placeholders in wpdb::prepare().

[41496] removed support for numbered placeholders in queries send through wpdb::prepare(), which, despite being undocumented, were quite commonly used.

This change restores support for numbered placeholders (as well as a subset of placeholder formatting), while also adding extra checks to ensure the correct number of arguments are being passed to wpdb::prepare(), given the number of placeholders.

See #41925.

File:

• trunk/src/wp-includes/meta.php (modified) (1 diff)

trunk/src/wp-includes/meta.php

@@ -365 +365 @@
 
     if ( $delete_all ) {
-        $value_clause = '';
         if ( '' !== $meta_value && null !== $meta_value && false !== $meta_value ) {
-            $value_clause = $wpdb->prepare( " AND meta_value = %s", $meta_value );
-        }
-
-        $object_ids = $wpdb->get_col( $wpdb->prepare( "SELECT $type_column FROM $table WHERE meta_key = %s $value_clause", $meta_key ) );
+            $object_ids = $wpdb->get_col( $wpdb->prepare( "SELECT $type_column FROM $table WHERE meta_key = %s AND meta_value = %s", $meta_key, $meta_value ) );
+        } else {
+            $object_ids = $wpdb->get_col( $wpdb->prepare( "SELECT $type_column FROM $table WHERE meta_key = %s", $meta_key ) );
+        }
     }