Changeset 42056 for trunk/tests/phpunit/tests/comment/query.php

Timestamp:

10/31/2017 11:59:43 AM (7 years ago)

Author:

pento

Message:

Database: Restore numbered placeholders in wpdb::prepare().

[41496] removed support for numbered placeholders in queries send through wpdb::prepare(), which, despite being undocumented, were quite commonly used.

This change restores support for numbered placeholders (as well as a subset of placeholder formatting), while also adding extra checks to ensure the correct number of arguments are being passed to wpdb::prepare(), given the number of placeholders.

See #41925.

File:

• trunk/tests/phpunit/tests/comment/query.php (modified) (2 diffs)

trunk/tests/phpunit/tests/comment/query.php

@@ -1219 +1219 @@
      */
     public function test_search_int_0_should_not_be_ignored() {
+        global $wpdb;
         $q = new WP_Comment_Query();
         $q->query( array(
             'search' => 0,
         ) );
-        $this->assertContains( "comment_author LIKE '%0%'", $q->request );
+        $this->assertContains( "comment_author LIKE '%0%'", $wpdb->remove_placeholder_escape( $q->request ) );
     }
 
@@ -1230 +1231 @@
      */
     public function test_search_string_0_should_not_be_ignored() {
+        global $wpdb;
         $q = new WP_Comment_Query();
         $q->query( array(
             'search' => '0',
         ) );
-        $this->assertContains( "comment_author LIKE '%0%'", $q->request );
+        $this->assertContains( "comment_author LIKE '%0%'", $wpdb->remove_placeholder_escape( $q->request ) );
     }