Make WordPress Core


Ignore:
Timestamp:
10/31/2017 12:50:23 PM (6 years ago)
Author:
pento
Message:

Database: Restore numbered placeholders in wpdb::prepare().

[41496] removed support for numbered placeholders in queries send through wpdb::prepare(), which, despite being undocumented, were quite commonly used.

This change restores support for numbered placeholders (as well as a subset of placeholder formatting), while also adding extra checks to ensure the correct number of arguments are being passed to wpdb::prepare(), given the number of placeholders.

Merges [41662], [42056] to the 4.2 branch.
See #41925.

Location:
branches/4.2
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • branches/4.2

  • branches/4.2/src/wp-includes/post.php

    r33556 r42063  
    42254225    $page_path = str_replace('%20', ' ', $page_path);
    42264226    $parts = explode( '/', trim( $page_path, '/' ) );
    4227     $parts = esc_sql( $parts );
    42284227    $parts = array_map( 'sanitize_title_for_query', $parts );
    4229 
    4230     $in_string = "'" . implode( "','", $parts ) . "'";
     4228    $escaped_parts = esc_sql( $parts );
     4229
     4230    $in_string = "'" . implode( "','", $escaped_parts ) . "'";
    42314231
    42324232    if ( is_array( $post_type ) ) {
Note: See TracChangeset for help on using the changeset viewer.