Changeset 42067 for branches/3.8/tests/phpunit/includes/testcase.php

Timestamp:

10/31/2017 12:59:50 PM (7 years ago)

Author:

pento

Message:

Database: Restore numbered placeholders in wpdb::prepare().

[41496] removed support for numbered placeholders in queries send through wpdb::prepare(), which, despite being undocumented, were quite commonly used.

This change restores support for numbered placeholders (as well as a subset of placeholder formatting), while also adding extra checks to ensure the correct number of arguments are being passed to wpdb::prepare(), given the number of placeholders.

Merges [41662], [42056] to the 3.8 branch.
See #41925.

Location:

branches/3.8

Files:

• . (modified) (1 prop)
• tests/phpunit/includes/testcase.php (modified) (1 diff)

branches/3.8/tests/phpunit/includes/testcase.php

@@ -123 +123 @@
             $this->fail( "Unexpected incorrect usage notice for $unexpected" );
         }
+    }
+
+    /**
+     * Declare an expected `_doing_it_wrong()` call from within a test.
+     *
+     * @since 4.2.0
+     *
+     * @param string $deprecated Name of the function, method, or class that appears in the first argument of the
+     *                           source `_doing_it_wrong()` call.
+     */
+    public function setExpectedIncorrectUsage( $doing_it_wrong ) {
+        array_push( $this->expected_doing_it_wrong, $doing_it_wrong );
     }