Changeset 42112

Timestamp:

11/02/2017 11:04:54 PM (9 years ago)

Author:

westonruter

Message:

Theme Editor: Ensure files listed recursively can be both viewed and edited.

Prevent edits to 2-level deep theme files from returning a disallowed_theme_file error when attempting to save an edit. Aligns logic for gathering $allowed_files in theme-editor.php for listing files with the validation logic in wp_edit_theme_plugin_file().

Amends [41806].
See #6531.
Fixes #42425.

File:

• trunk/src/wp-admin/includes/file.php (modified) (1 diff)

trunk/src/wp-admin/includes/file.php

@@ -433 +433 @@
                         switch ( $type ) {
                                 case 'php':
-                                        $allowed_files = array_merge( $allowed_files, $theme->get_files( 'php', 1 ) );
+                                        $allowed_files = array_merge( $allowed_files, $theme->get_files( 'php', -1 ) );
                                         break;
                                 case 'css':
-                                        $style_files = $theme->get_files( 'css' );
+                                        $style_files = $theme->get_files( 'css', -1 );
                                         $allowed_files['style.css'] = $style_files['style.css'];
                                         $allowed_files = array_merge( $allowed_files, $style_files );
                                         break;
                                 default:
-                                        $allowed_files = array_merge( $allowed_files, $theme->get_files( $type ) );
+                                        $allowed_files = array_merge( $allowed_files, $theme->get_files( $type, -1 ) );
                                         break;
                         }