Changeset 42217 for trunk/src/wp-admin/options-general.php

Timestamp:

11/23/2017 04:08:42 AM (7 years ago)

Author:

pento

Message:

General: Reformat inline if () statements inside HTML tags.

This pattern occurs a handful of times across the codebase:

<div class="foo<?php if ( $bar ) { echo ' baz'; } ?>">

Unfortunately, it doesn't really play nicely with phpcbf, so all instances need to be removed in preperation for auto code formatting.

See #41057.

File:

• trunk/src/wp-admin/options-general.php (modified) (1 diff)

trunk/src/wp-admin/options-general.php

@@ -69 +69 @@
 </tr>
 
-<?php if ( !is_multisite() ) { ?>
+<?php
+    if ( !is_multisite() ) {
+        $wp_site_url_class = $wp_home_class = '';
+        if ( defined( 'WP_SITEURL' ) ) {
+            $wp_site_url_class = ' disabled';
+        }
+        if ( defined( 'WP_HOME' ) ) {
+            $wp_home_class = ' disabled';
+        }
+?>
 
 <tr>
 <th scope="row"><label for="siteurl"><?php _e('WordPress Address (URL)') ?></label></th>
-<td><input name="siteurl" type="url" id="siteurl" value="<?php form_option( 'siteurl' ); ?>"<?php disabled( defined( 'WP_SITEURL' ) ); ?> class="regular-text code<?php if ( defined( 'WP_SITEURL' ) ) echo ' disabled' ?>" /></td>
+<td><input name="siteurl" type="url" id="siteurl" value="<?php form_option( 'siteurl' ); ?>"<?php disabled( defined( 'WP_SITEURL' ) ); ?> class="regular-text code<?php echo $wp_site_url_class; ?>" /></td>
 </tr>
 
 <tr>
 <th scope="row"><label for="home"><?php _e('Site Address (URL)') ?></label></th>
-<td><input name="home" type="url" id="home" aria-describedby="home-description" value="<?php form_option( 'home' ); ?>"<?php disabled( defined( 'WP_HOME' ) ); ?> class="regular-text code<?php if ( defined( 'WP_HOME' ) ) echo ' disabled' ?>" />
+<td><input name="home" type="url" id="home" aria-describedby="home-description" value="<?php form_option( 'home' ); ?>"<?php disabled( defined( 'WP_HOME' ) ); ?> class="regular-text code<?php echo $wp_home_class; ?>" />
 <?php if ( ! defined( 'WP_HOME' ) ) : ?>
 <p class="description" id="home-description"><?php