Changeset 42217 for trunk/src/wp-includes/customize/class-wp-customize-nav-menu-location-control.php

Timestamp:

11/23/2017 04:08:42 AM (3 years ago)

Author:

pento

Message:

General: Reformat inline if () statements inside HTML tags.

This pattern occurs a handful of times across the codebase:

<div class="foo<?php if ( $bar ) { echo ' baz'; } ?>">

Unfortunately, it doesn't really play nicely with phpcbf, so all instances need to be removed in preperation for auto code formatting.

See #41057.

File:

• trunk/src/wp-includes/customize/class-wp-customize-nav-menu-location-control.php (modified) (2 diffs)

trunk/src/wp-includes/customize/class-wp-customize-nav-menu-location-control.php

@@ -57 +57 @@
             return;
         }
+
+        $value_hidden_class = $no_value_hidden_class = '';
+        if ( $this->value() ) {
+            $value_hidden_class = ' hidden';
+        } else {
+            $no_value_hidden_class = ' hidden';
+        }
         ?>
         <label>
@@ -75 +82 @@
             </select>
         </label>
-        <button type="button" class="button-link create-menu<?php if ( $this->value() ) { echo ' hidden'; } ?>" data-location-id="<?php echo esc_attr( $this->location_id ); ?>" aria-label="<?php esc_attr_e( 'Create a menu for this location' ); ?>"><?php _e( '+ Create New Menu' ); ?></button>
-        <button type="button" class="button-link edit-menu<?php if ( ! $this->value() ) { echo ' hidden'; } ?>" aria-label="<?php esc_attr_e( 'Edit selected menu' ); ?>"><?php _e( 'Edit Menu' ); ?></button>
+        <button type="button" class="button-link create-menu<?php echo $value_hidden_class; ?>" data-location-id="<?php echo esc_attr( $this->location_id ); ?>" aria-label="<?php esc_attr_e( 'Create a menu for this location' ); ?>"><?php _e( '+ Create New Menu' ); ?></button>
+        <button type="button" class="button-link edit-menu<?php echo $no_value_hidden_class; ?>" aria-label="<?php esc_attr_e( 'Edit selected menu' ); ?>"><?php _e( 'Edit Menu' ); ?></button>
         <?php
     }