Changeset 42217 for trunk/src/wp-includes/widgets/class-wp-nav-menu-widget.php

Timestamp:

11/23/2017 04:08:42 AM (7 years ago)

Author:

pento

Message:

General: Reformat inline if () statements inside HTML tags.

This pattern occurs a handful of times across the codebase:

<div class="foo<?php if ( $bar ) { echo ' baz'; } ?>">

Unfortunately, it doesn't really play nicely with phpcbf, so all instances need to be removed in preperation for auto code formatting.

See #41057.

File:

• trunk/src/wp-includes/widgets/class-wp-nav-menu-widget.php (modified) (3 diffs)

trunk/src/wp-includes/widgets/class-wp-nav-menu-widget.php

@@ -121 +121 @@
         $menus = wp_get_nav_menus();
 
+        $empty_menus_style = $not_empty_menus_style = '';
+        if ( empty( $menus ) ) {
+            $empty_menus_style = ' style="display:none" ';
+        } else {
+            $not_empty_menus_style = ' style="display:none" ';
+        }
+
+        $nav_menu_style = '';
+        if ( ! $nav_menu ) {
+            $nav_menu_style = 'display: none;';
+        }
+
         // If no menus exists, direct the user to go and create some.
         ?>
-        <p class="nav-menu-widget-no-menus-message" <?php if ( ! empty( $menus ) ) { echo ' style="display:none" '; } ?>>
+        <p class="nav-menu-widget-no-menus-message" <?php echo $not_empty_menus_style; ?>>
             <?php
             if ( $wp_customize instanceof WP_Customize_Manager ) {
@@ -133 +145 @@
             <?php echo sprintf( __( 'No menus have been created yet. <a href="%s">Create some</a>.' ), esc_attr( $url ) ); ?>
         </p>
-        <div class="nav-menu-widget-form-controls" <?php if ( empty( $menus ) ) { echo ' style="display:none" '; } ?>>
+        <div class="nav-menu-widget-form-controls" <?php echo $empty_menus_style; ?>>
             <p>
                 <label for="<?php echo $this->get_field_id( 'title' ); ?>"><?php _e( 'Title:' ) ?></label>
@@ -150 +162 @@
             </p>
             <?php if ( $wp_customize instanceof WP_Customize_Manager ) : ?>
-                <p class="edit-selected-nav-menu" style="<?php if ( ! $nav_menu ) { echo 'display: none;'; } ?>">
+                <p class="edit-selected-nav-menu" style="<?php echo $nav_menu_style; ?>">
                     <button type="button" class="button"><?php _e( 'Edit Menu' ) ?></button>
                 </p>