Changeset 42224

Timestamp:

11/24/2017 03:04:35 AM (7 years ago)

Author:

dd32

Message:

Filesystem: Use a more unique filename in wp_tempnam() and get_filesystem_method().
Using a filename which was generated from time() could cause two processes to try to use the same filename, causing unexpected behaviour.

Props jrchamp, bikecrazyy.
Fixes #42265.

File:

• trunk/src/wp-admin/includes/file.php (modified) (2 diffs)

trunk/src/wp-admin/includes/file.php

@@ -625 +625 @@
 
     if ( empty( $filename ) || '.' == $filename || '/' == $filename || '\\' == $filename ) {
-        $filename = time();
+        $filename = uniqid();
     }
 
@@ -1467 +1467 @@
     if ( ! $method ) {
 
-        $temp_file_name = $context . 'temp-write-test-' . time();
+        $temp_file_name = $context . 'temp-write-test-' . str_replace( '.', '-', uniqid( '', true ) );
         $temp_handle = @fopen($temp_file_name, 'w');
         if ( $temp_handle ) {