Changeset 42245 for branches/4.9

Timestamp:

11/27/2017 03:28:00 AM (6 years ago)

Author:

dd32

Message:

Theme Editor: Validate files are editable based on their relative filenames, rather than full file path.

This fixes theme editing on Windows platforms where validate_file() will return 2 on a full file path.

Merges [42244] to the 4.9 branch.
Fixes #42609.

Location:

branches/4.9

Files:

• . (modified) (1 prop)
• src/wp-admin/includes/file.php (modified) (1 diff)

branches/4.9/src/wp-admin/includes/file.php

@@ -446 +446 @@
         }
 
-        if ( 0 !== validate_file( $real_file, $allowed_files ) ) {
+        // Compare based on relative paths
+        if ( 0 !== validate_file( $file, array_keys( $allowed_files ) ) ) {
             return new WP_Error( 'disallowed_theme_file', __( 'Sorry, that file cannot be edited.' ) );
         }