Changeset 42249 for trunk/src/wp-includes/shortcodes.php

Timestamp:

11/28/2017 04:23:11 AM (7 years ago)

Author:

pento

Message:

General: Add inline PHPCS options to leave regex indentation.

We have a handful of super long regexen that are written over multiple lines, as a collection of strings concatenated together. Each string is indented appropriately for the regex, but PHPCS doesn't recognised this, so defaults to removing the extra whitespace.

Disabling the Squiz.Strings.ConcatenationSpacing.PaddingFound rule for these blocks stops the extra whitespace from being removed.

See #41057.

File:

• trunk/src/wp-includes/shortcodes.php (modified) (2 diffs)

trunk/src/wp-includes/shortcodes.php

@@ -236 +236 @@
     // WARNING! Do not change this regex without changing do_shortcode_tag() and strip_shortcode_tag()
     // Also, see shortcode_unautop() and shortcode.js.
+
+    // phpcs:disable Squiz.Strings.ConcatenationSpacing.PaddingFound -- don't remove regex indentation
     return
-        '\\['                              // Opening bracket
+        '\\['                                // Opening bracket
         . '(\\[?)'                           // 1: Optional second opening bracket for escaping shortcodes: [[tag]]
         . "($tagregexp)"                     // 2: Shortcode name
@@ -265 +267 @@
         . ')'
         . '(\\]?)';                          // 6: Optional second closing brocket for escaping shortcodes: [[tag]]
+    // phpcs:enable
 }