Changeset 42257

Timestamp:

11/29/2017 03:27:55 PM (7 years ago)

Author:

SergeyBiryukov

Message:

Users: After [42256], remove unnecessary double quotes around first_name and last_name properties.

See #42713.

Location:

trunk/src/wp-admin/includes

Files:

• class-wp-ms-users-list-table.php (modified) (1 diff)
• class-wp-users-list-table.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-wp-ms-users-list-table.php

@@ -267 +267 @@
         if ( $user->first_name && $user->last_name ) {
             echo "$user->first_name $user->last_name";
-        } else if ( ! empty( $user->first_name ) ) {
-            echo "$user->first_name";
-        } else if ( ! empty( $user->last_name ) ) {
-            echo "$user->last_name";
+        } elseif ( $user->first_name ) {
+            echo $user->first_name;
+        } elseif ( $user->last_name ) {
+            echo $user->last_name;
         } else {
             echo '<span aria-hidden="true">&#8212;</span><span class="screen-reader-text">' . _x( 'Unknown', 'name' ) . '</span>';

trunk/src/wp-admin/includes/class-wp-users-list-table.php

@@ -489 +489 @@
                         if ( $user_object->first_name && $user_object->last_name ) {
                             $r .= "$user_object->first_name $user_object->last_name";
-                        } else if ( ! empty( $user_object->first_name ) ) {
-                            $r .= "$user_object->first_name";
-                        } else if ( ! empty( $user_object->last_name) ) {
-                            $r .= "$user_object->last_name";
+                        } elseif ( $user_object->first_name ) {
+                            $r .= $user_object->first_name;
+                        } elseif ( $user_object->last_name ) {
+                            $r .= $user_object->last_name;
                         } else {
                             $r .= '<span aria-hidden="true">&#8212;</span><span class="screen-reader-text">' . _x( 'Unknown', 'name' ) . '</span>';